Silence duplicate -rpath linker warnings on macOS#32869
Open
lindsayad wants to merge 1 commit intoidaholab:nextfrom
Open
Silence duplicate -rpath linker warnings on macOS#32869lindsayad wants to merge 1 commit intoidaholab:nextfrom
lindsayad wants to merge 1 commit intoidaholab:nextfrom
Conversation
Contributor
|
Job Test, step Results summary on 19714e5 wanted to post the following: Framework test summaryCompared against 10e0ca6 in job civet.inl.gov/job/3797958. No change Modules test summaryCompared against 10e0ca6 in job civet.inl.gov/job/3797958. No change |
Contributor
|
Job Documentation, step Docs: sync website on 19714e5 wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
Job Coverage, step Generate coverage on 19714e5 wanted to post the following: Framework coverageCoverage did not change Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
GiudGiud
reviewed
May 6, 2026
| # dependency (libmesh, timpi, petsc) that share an installation prefix, producing | ||
| # duplicate -rpath entries that macOS ld warns about. | ||
| libmesh_LIBS := $(shell printf '%s\n' $(libmesh_LIBS) | awk '!seen[$$0]++' | tr '\n' ' ') | ||
| libmesh_LDFLAGS := $(shell printf '%s\n' $(libmesh_LDFLAGS) | awk '!seen[$$0]++' | tr '\n' ' ') |
Contributor
There was a problem hiding this comment.
I d keep that. it does not silence the warning but it limits the number of duplicates to read through when debugging the build
The prior approach (removed from build.mk) deduplicated libmesh_LIBS and libmesh_LDFLAGS, but duplicate -rpath entries can also arrive from libtool itself or other link inputs (LDFLAGS, curr_additional_libs), so removing duplicates from only those two variables did not fully suppress the warning. Replace it with a source-agnostic approach: wrap linker invocations in bash -c to enable process substitution, then extend SILENCE_SOME_WARNINGS to also filter 'duplicate -rpath' lines from stderr. Refs idaholab#31412 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lindsayad
force-pushed
the
really-silence-linker-warnings
branch
from
19714e5 to
91a1211
Compare
GiudGiud
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior approach (removed from
build.mk) deduplicatedlibmesh_LIBSandlibmesh_LDFLAGS, but duplicate-rpathentries can also arrive from libtool itself or other link inputs (LDFLAGS,curr_additional_libs), so removing duplicates from only those two variables did not fully suppress the warning.Replace it with a source-agnostic approach: wrap linker invocations in
bash -cto enable process substitution, then extendSILENCE_SOME_WARNINGSto also filter duplicate-rpathlines from stderr.Refs #31412