Treat Console the same as other output objects#32873
Draft
lindsayad wants to merge 5 commits intoidaholab:nextfrom
Draft
Treat Console the same as other output objects#32873lindsayad wants to merge 5 commits intoidaholab:nextfrom
lindsayad wants to merge 5 commits intoidaholab:nextfrom
Conversation
Contributor
|
Job Documentation, step Docs: sync website on 3231650 wanted to post the following: View the site here This comment will be updated on new commits. |
In my opinion we don't want an action's defaults overriding specific output derived class defaults. It's silly to me to think that the common output action defaults could possibly be generically superior to object defaults. And that's irrespective of the derived output object type, e.g. we should not be treating Console specially. With this refactor we can remove the special exclude execute_on parameter handling when adding the output object in FEProblemBase. It was very brittle and non-extensible to think that users should come modify FEProblemBase whenever they needed to set better defaults for their object. Closes idaholab#4497 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lindsayad
force-pushed
the
fix-console
branch
2 times, most recently
from
115959c to
b6482f4
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Job Test, step Results summary on 57f20e0 wanted to post the following: Framework test summaryCompared against 10e0ca6 in job civet.inl.gov/job/3797958. No change Modules test summaryCompared against 10e0ca6 in job civet.inl.gov/job/3797958. No change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my opinion we don't want an action's defaults overriding
specific output derived class defaults. It's silly to me to
think that the common output action defaults could possibly
be generically superior to object defaults. And that's
irrespective of the derived output object type, e.g. we should
not be treating Console specially. With this refactor we can
remove the special exclude execute_on parameter handling when
adding the output object in FEProblemBase. It was very brittle
and non-extensible to think that users should come modify
FEProblemBase whenever they needed to set better defaults for their
object.
Closes #4497