This repository was archived by the owner on Jan 16, 2021. It is now read-only.
Fix validChars for multi-byte file name #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added options to
a) support :w as substitute for :Ren, and
b) ignore wildignore settings when reading in files.
Fixed a bug with highlighting after file deletion.
Various other minor changes, eg naming the buffer.
Fix filename handling for linux - thanks Antonio Monizio Improve :w support to avoid delay showing command line - thanks Sergey Bochenkov Other minor improvements
1.3 - check that proposed filenames are valid before applying them
- add support for creating required directories - thanks to Glen Miner
for the request that made it finally happen.
- fix location of intermediate files to be the same as the source file.
(Particularly important for large files on slow-access media, as
they were being copied to and from local media.)
Thanks to Adam Courtemanche for finding and fixing the bug!
- fix permitted filenames problem on Mac OS - thanks Adam Courtemanche. - fix bug when launching from within an existing buffer.
Retab with 2-space tabs (most of it already was) and use indent for folding so I can more easily separate functions for autoload.
Since the mappings are defined in a function and they call functions defined in this script, we're storing the SID value so we can bypass the name mangling. Remove all of that. I think we can do this better using <Plug>. Users would be able to define mappings, but that's not so bad. For now I'm removing it all so I can move stuff to autoload before bringing it back (if necessary).
Extract the interface. We only need this one function in our API. Everything else can be autoloaded. Sort out the varargs before we pass on to autoload.
Should strive to avoid redefining instead of clobbering. I don't think autoloaded plugins should get reloaded.
Moved functions (except for interface) and script variables into
autoload.
Fixed names with:
%sm/renamer#StartRenamer/renamer#Start
Removed the load guard since autoload shouldn't get loaded multiple
times.
Move documentation so you can read it with :help. Update installation for bundle. Bump version to 2.0 and update change date. Change fdm back to marker.
Expose the plug map so users can use it.
For help, see doc/renamer.txt instead.
Since switching back to the buffer doesn't re-load renamer, just clea the buffer.
Owner
|
Hi dobogo, FYI, I'm not the maintainer of renamer.vim (so your change won't get on vim.org). You can contact him directly though. I'm curious about your commit. Can you provide a test case for this issue? (Just a comment on this pull request with some examples that fail. Assuming github lets you post comments with multi-byte characters in them.) |
Author
|
Hi pydave, Here are some file names that fail. Symbols: Arabic characters: Japanese characters: Russian characters: |
idbrii
force-pushed
the
master
branch
2 times, most recently
from
e020c53 to
fd23361
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original validChars does not accept multi-byte characters while these are valid in file name.