Add verifyAll and change the verify(verificationLevel, options)#104
Open
jpsantosbh wants to merge 2 commits intomasterfrom
Open
Add verifyAll and change the verify(verificationLevel, options)#104jpsantosbh wants to merge 2 commits intomasterfrom
jpsantosbh wants to merge 2 commits intomasterfrom
Conversation
…om the verify(verificationLevel, options)
dankelleher
reviewed
May 9, 2019
| return verifiedlevel; | ||
| }; | ||
|
|
||
| this.verifyAll = async (options) => { |
Contributor
Author
There was a problem hiding this comment.
Not yet... Only proposing it :-)
|
|
||
| // Test next level | ||
| if (verifiedlevel === VERIFY_LEVELS.PROOFS | ||
| && hVerifyLevel >= VERIFY_LEVELS.ANCHOR |
Member
There was a problem hiding this comment.
Is it correct that verify(leve) can now verify everything up to Anchor but not including Anchor? If so this should be probably documented.
Contributor
Author
There was a problem hiding this comment.
Yes you are correct needs better documentation
| }); | ||
|
|
||
| it('should check all verifications and fail - tampered grant', async (done) => { | ||
| const credentialContents = fs.readFileSync('__test__/creds/fixtures/VCPermanentAnchor.json', 'utf8'); |
Contributor
There was a problem hiding this comment.
I think that a require in test/creds/fixtures/VCPermanentAnchor.json is better.
Contributor
Author
There was a problem hiding this comment.
The anchor on this test is not checked. it fails before that.
| }); | ||
|
|
||
| it('should check all verifications and fail - tampered claims', async (done) => { | ||
| const credentialContents = fs.readFileSync('__test__/creds/fixtures/VCPermanentAnchor.json', 'utf8'); |
| }); | ||
|
|
||
| it('should check all verifications and fail - anchor fails', async (done) => { | ||
| const credentialContents = fs.readFileSync('__test__/creds/fixtures/VCPermanentAnchor.json', 'utf8'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
verifyAttestation()ins an ASYNC method it can't be part of theverifymethod. Changing the verify method to async will impact a lot of implementation that doesn't need to verify the anchor. This PR has a proposal to add a new ASYNC verification methodverifyAlland remove the anchor verification for theverifymethod