Create GUI#240
Conversation
|
@ifd3f can we maybe disable (the heaviest?) CI workflows until I'm ready for review? Seems like a waste of resources when I'm developing. |
I could disable it but also that's effort and I don't feel like doing CI configuration lol |
…et disk selection
drop/revert this commit later! just for skipping CI when i'm in draft
This reverts commit 15d74f6.
…d try to get writing to work not working yet
…a local tokio runtime there. That'sinsane.
… to create worker thread
|
re-starting based off |
|
I just realized have a few more components I need to move into orchestrator before you can get the GUI done -- file analysis, disk enumeration, and hashing. How about this -- I'll go define some stub methods on the orchestrator along with expected output structs. As usual, overall shape will remain the same but exact internals, like error types and such, may be subject to change. |
|
Oh ok , yeah that sounds good! Otherwise I can just back off and you can ping me whenever it's ready! |
|
@sermuns: I made #244. As mentioned earlier, they're just stub methods, so if you want to test your UI's functionality, you'll have to manually fill in their On the bright side, I think that this is the last thing that's needed before you should be able to continue. Who knew that writing well-defined facades was a good idea? |
|
Okay, whoops, one more design choice. I decided I actually want to split Orchestrator into a bunch of subtraits because it's getting quite big. The PR to make that happen will be out soon. |
Renames most of the stuff that needed to be renamed. Sorry about the churn!
|
I merged my facade split branch in and renamed most of the relevant things that needed to be renamed. Feel free to rearrange the git history with a rebase if you'd like. |
|
will this be optional (or even better imo, additionally installed) |
|
@linux-universe yes -- it's going to be gated behind a feature flag and we'd just distribute |
|
I am a bit swamped with university until mid June, hoping to make more progress then! |
|
No worries, totally understandable! Would you be fine if I made some additions to this as well? |
|
You are very welcome, feel free to do massive changes, this is your project! Some parts of the draft PR I already know needs to change!
|
Closes #5 (eventually).
I'm creating this draft PR already, even though the GUI can't do shit yet!