Fix engine#804
Conversation
- Added new dependencies in pnpm-workspace.yaml including vue-router and lodash-es. - Configured allowBuilds for specific packages to control build behavior. - Updated remote address in conf.yaml to use the new API endpoint. - Changed app_auth_type from casdoor to uap for authentication.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces localization updates across English and Chinese locales, updates dependency configurations to utilize the pnpm workspace catalog, and refactors the server process startup to use spawn instead of exec. Feedback highlights a critical issue with a non-existent lodash version in electron-app/package.json that will cause installation failures. Additionally, it is recommended to centralize shared dependencies like i18next, i18next-vue, crypto-js, and dayjs into the workspace catalog to prevent version drift and maintain consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "electron-log": "^5.4.3", | ||
| "electron-updater": "^6.7.3", | ||
| "lodash-es": "^4.17.21", | ||
| "lodash": "^4.18.1", |
There was a problem hiding this comment.
The dependency lodash specifies version ^4.18.1, which does not exist on npm. The latest stable version of lodash is 4.17.21. Specifying a non-existent version will cause installation and resolution failures during pnpm install.
Please downgrade/update this to a valid version like ^4.17.21.
| "lodash": "^4.18.1", | |
| "lodash": "^4.17.21", |
| "i18next": "^25.3.6", | ||
| "i18next-vue": "^5.3.0" |
There was a problem hiding this comment.
The peer dependencies i18next and i18next-vue are also used in frontend/packages/web-app/package.json with the exact same versions. To prevent version drift and maintain a single source of truth across the monorepo, these dependencies should be moved to the central catalog in frontend/pnpm-workspace.yaml and referenced using the catalog: protocol.
Additionally, since these are peer dependencies, they should also be added to devDependencies of @rpa/components to ensure they are available during local development and isolated builds.
| "i18next": "^25.3.6", | |
| "i18next-vue": "^5.3.0" | |
| "i18next": "catalog:", | |
| "i18next-vue": "catalog:" |
| tailwind-merge: ^3.4.0 | ||
| tailwindcss: "^3.4.4" | ||
| tsdown: "^0.20.1" | ||
| lodash-es: "^4.17.21" |
There was a problem hiding this comment.
Consider adding other shared dependencies like crypto-js, dayjs, i18next, and i18next-vue to the central catalog in pnpm-workspace.yaml. Currently, there is a version mismatch for dayjs (^1.11.19 in components vs ^1.11.18 in web-app), and crypto-js is duplicated across multiple packages. Centralizing them in the catalog will prevent version drift and simplify dependency updates.
lodash-es: "^4.17.21"
i18next: "^25.3.6"
i18next-vue: "^5.3.0"
crypto-js: "^4.2.0"
dayjs: "^1.11.19"
1 participant
📝 Pull Request 描述 | Description
🎯 变更类型 | Change Type
🔗 相关 Issue | Related Issues
📋 变更内容 | Changes Made
主要变更 | Main Changes
技术细节 | Technical Details
🧪 测试 | Testing
测试环境 | Test Environment
测试步骤 | Test Steps
测试结果 | Test Results
📸 截图/录屏 | Screenshots/Recordings
变更前 | Before
变更后 | After
破坏性变更详情 | Breaking Changes Details
✅ 检查清单 | Checklist
代码质量 | Code Quality
测试 | Testing
文档 | Documentation
其他 | Others
📌 额外说明 | Additional Notes
🙏 致谢 | Acknowledgements
📖 提示 | Tips:
/cc @maintainers