fix(compat): enforce anonymous installability rules#514
Closed
dongmucat wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Technical review requested for ISSUE-39. Focus areas:
Verification completed:
|
Collaborator
Author
|
Closing as superseded by replacement PR #523 for ISSUE-36. Keeping branch intact; no merge to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
Enforce the anonymous CLI installability contract consistently across search, resolve, and download for ISSUE-39.
变更内容
后端实现
AnonymousSkillInstallabilityPolicyfor the anonymous public install target rule: active namespace, active/non-hidden/public skill, and published/download-ready/non-yanked version.前端实现
测试覆盖
AnonymousSkillInstallabilityPolicyTest,SkillSearchAppServiceTest,SkillQueryServiceTest,SkillDownloadServiceTestcover the positive public installable case and negative cases for archived/hidden/private/unpublished/no latest/not ready/yanked versions.质量门禁
make test-backend-apppassedmake typecheck-webpassedmake lint-webpassedmake generate-apinot required; no Controller/API contract changemake stagingattempted twice and blocked by Docker registry TLS failure while resolvingeclipse-temurin:21-jre-alpinefromregistry-1.docker.io安全考虑
相关 Issue
Closes ISSUE-39
测试说明
本地验证步骤
make test-backend-appand expect the backend reactor to pass.make typecheck-webandmake lint-webto verify unchanged frontend checks.make stagingonce Docker registry TLS resolution is healthy.回归测试范围
/api/v1/searchshould only include skills whose latest version is installable./api/v1/resolveand/api/v1/downloadshould reject non-installable public targets before file/storage fallback work.截图/录屏(如有 UI 变更)
No UI changes.