feat(bootstrap): add agentguard builtin skill#526
Open
dongmucat wants to merge 1 commit into
Open
Conversation
d977317 to
1fbc26f
Compare
Signed-off-by: dongmucat <1127093059@qq.com>
1fbc26f to
abdad25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
新增 AgentGuard 作为 cloud-url built-in skill,并补齐 SKILL.md
metadata.version版本字段兼容,确保启动同步时 manifest 版本校验可以通过。变更内容
后端实现
server/skillhub-app/src/main/resources/builtin-skills/manifest.json新增agentguard条目。SkillMetadataParser中增加顶层version缺失时读取metadata.version的 fallback。version优先级不变:当version与metadata.version同时存在时仍使用顶层字段。前端实现
测试覆盖
SkillMetadataParserTest.testUsesMetadataVersionWhenTopLevelVersionIsMissing,覆盖 AgentGuard 包的 metadata 版本格式。SkillMetadataParserTest.testTopLevelVersionTakesPrecedenceOverMetadataVersion,覆盖向后兼容优先级。BuiltinSkillManifestLoaderTest、BuiltinSkillPackageExtractorTest、BuiltinSkillInitializerTest。web/src变更,未触发 Playwright E2E 必跑条件;远端 PR E2E 已通过。质量门禁
make typecheck-web通过(0 errors)make lint-web通过(0 errors, 0 warnings)make test-frontend通过(180 files / 601 tests)make test-backend-app通过(526 tests, 0 failures, 0 errors)SkillMetadataParserTest11 tests,built-in loader/extractor/initializer 25 testsmake staging本地未完成:Docker Hub 拉取eclipse-temurin:21-jre-alpine时出现TLS handshake timeoutmake generate-api不适用:未修改 Controller / OpenAPI 契约安全考虑
metadata.version的读取,不扩大执行或下载权限。相关 Issue
Related to #477
测试说明
本地验证步骤
builtin-skills/manifest.json。agentguard包的name=agentguard、metadata.version=1.1与 manifest 条目一致。@global/agentguard可按现有 built-in skill 同步路径发布为 public skill。回归测试范围
version字段解析保持不变。截图/录屏(如有 UI 变更)
本次无 UI 变更。