Fix admin notifications for profile review requests#530
Conversation
|
Code review finding (blocking): Please change the target contract to a route the current frontend can handle for profile reviews, or include the needed frontend route/search handling in this PR. The API docs and tests should assert that Verification I ran locally:
Also noted: current GitHub checks still show DCO failing and E2E pending, so the PR cannot be merge-ready yet even apart from the routing issue. Note: I attempted to submit this as a formal “request changes” review, but GitHub rejected it because the authenticated GitHub user is the PR author. |
Signed-off-by: dongmucat <1127093059@qq.com>
bd18e87 to
a865960
Compare
Signed-off-by: dongmucat <1127093059@qq.com>
修复内容
PROFILE_REVIEW_SUBMITTED。REVIEWcategory,收件人限定为USER_ADMIN/SUPER_ADMIN,避免发给无资料审核权限的SKILL_ADMIN。/dashboard/reviews?type=profile,管理员点击后进入资料审核队列,而不是技能审核详情页。profileReviewId、submitterId、fields等必要字段。/api/web/notifications/sse被响应缓存截断的问题,保持 SSE 长连接,并恢复实时 notification event 与实时未读 badge 推送。验证结果
make test-backend-appmake typecheck-webmake lint-webscripts/check-openapi-generated.shpnpm exec vitest run src/pages/dashboard/reviews.test.tspnpm exec vitest run src/features/notification/notification-target.test.ts/api/web/notifications/sse返回Transfer-Encoding: chunked,无Content-Length,客户端超时前连接保持打开。Fixes #524