fix(cli): treat highlighted install target as selected#534
Open
SenLinLeo wants to merge 1 commit into
Open
Conversation
bbf4357 to
9ed5bee
Compare
Signed-off-by: SenLinLeo <1664761477@qq.com>
9ed5bee to
b44c654
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
When
skillhub installdetects multiple install targets, users can move the cursor to a target and press Enter expecting that row to be confirmed. In this flow,promptscan return an empty selection unless the user first checks anitem, so the CLI currently treats it as cancellation.
Falling back to the highlighted target makes Enter behave like confirm while keeping the existing multiselect flow intact.
Tests
bun test test/unit/agents/resolver-interactive.test.ts test/unit/agents/resolver.test.tsbun run typecheckbun run lintbun run buildbun test