Skip to content

fix(cli): treat highlighted install target as selected#534

Open
SenLinLeo wants to merge 1 commit into
iflytek:mainfrom
SenLinLeo:fix/install-target-enter-selection
Open

fix(cli): treat highlighted install target as selected#534
SenLinLeo wants to merge 1 commit into
iflytek:mainfrom
SenLinLeo:fix/install-target-enter-selection

Conversation

@SenLinLeo

@SenLinLeo SenLinLeo commented Jun 16, 2026

Copy link
Copy Markdown

Summary

  • Treat the currently highlighted install target as selected when the interactive multiselect prompt submits an empty selection.
  • Preserve the existing explicit multiselect behavior; only empty submissions use the highlighted fallback.
  • Add a unit test covering the Enter-on-highlighted-target path.

Why

When skillhub install detects multiple install targets, users can move the cursor to a target and press Enter expecting that row to be confirmed. In this flow, prompts can return an empty selection unless the user first checks an
item, so the CLI currently treats it as cancellation.

Falling back to the highlighted target makes Enter behave like confirm while keeping the existing multiselect flow intact.

Tests

  • bun test test/unit/agents/resolver-interactive.test.ts test/unit/agents/resolver.test.ts
  • bun run typecheck
  • bun run lint
  • bun run build
  • bun test

@CLAassistant

CLAassistant commented Jun 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@SenLinLeo SenLinLeo force-pushed the fix/install-target-enter-selection branch from bbf4357 to 9ed5bee Compare June 16, 2026 08:26
Signed-off-by: SenLinLeo <1664761477@qq.com>
@SenLinLeo SenLinLeo force-pushed the fix/install-target-enter-selection branch from 9ed5bee to b44c654 Compare June 16, 2026 08:30
@SenLinLeo

Copy link
Copy Markdown
Author
image It has no impact on historical logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants