Skip to content

Fixed regex in create_event #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lugb2 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed regex in create_event #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dae0d01
Fixed regex issue in function create_event, aligning it with the patt…
lugb2 Feb 5, 2024
b442ab3
Merge branch 'ifsnop:master' into fixCreateEventRegex
lugb2 Sep 20, 2024
77d2b37
Added create event statement at test012 for definer validation
lugb2 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Ifsnop/Mysqldump/Mysqldump.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,7 +2077,7 @@ public function create_event($row)
$definerStr = $this->dumpSettings['skip-definer'] ? '' : '/*!50117 \2*/ ';

if ($eventStmtReplaced = preg_replace(
'/^(CREATE)\s+('.self::DEFINER_RE.')?\s+(EVENT .*)$/',
'/^(CREATE)\s+('.self::DEFINER_RE.')?\s+(EVENT\s.*)$/s',
'/*!50106 \1*/ '.$definerStr.'/*!50106 \3 */',
$eventStmt,
1
Expand Down
8 changes: 8 additions & 0 deletions tests/test012.src.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,11 @@ BEGIN
SELECT * FROM test012;
END ;;
DELIMITER ;

CREATE EVENT `test012_event`
ON SCHEDULE EVERY 1 DAY
ON COMPLETION PRESERVE ENABLE
DO begin

select 1;
end;