Skip to content

Commit 86facdd

Browse files
committed
PR #457 R2 polish: refresh stale Test Coverage activation note
R2 verdict was Looks good with 1 P3 informational item. METHODOLOGY_REVIEW.md Test Coverage line read "all active; R parity activates once goldens are committed" - stale after this PR commits the goldens and activates the 3 R-parity tests. Updated to reflect the post-PR state: all 33 tests active including R-parity (with pointer to the committed JSON).
1 parent e73a6c4 commit 86facdd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

METHODOLOGY_REVIEW.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,7 @@ and covariate-adjusted specifications.)
929929
- [x] R `bacondecomp::bacon()` parity at `atol=1e-6` — 3 fixtures (`uniform_3groups_with_never_treated`, `two_groups_no_never_treated`, `always_treated_remapped`); TWFE coefficient + weights-sum match across all 3 fixtures; per-component estimate + weight parity locked on the 2 non-remap fixtures, with a documented convention divergence on `always_treated_remapped` (Python's footnote-11 U-remap vs R's distinct `Later vs Always Treated` cohort decomposition — aggregate is invariant, breakdown is structurally different). See `benchmarks/data/r_bacondecomp_golden.json` + `TestBaconParityR`.
930930

931931
**Test Coverage:**
932-
- 33 methodology tests in `tests/test_methodology_bacon.py` across 6 classes (all active; R parity activates once goldens are committed)
932+
- 33 methodology tests in `tests/test_methodology_bacon.py` across 6 classes all active, including the 3 R-parity tests (goldens committed at `benchmarks/data/r_bacondecomp_golden.json`)
933933
- 32 existing tests in `tests/test_bacon.py` (basic decomposition, weight properties, weights-parameter API, TWFE integration, visualization, balanced-panel warnings, edge cases)
934934

935935
**R Comparison Results:**

0 commit comments

Comments
 (0)