Commit a21cd5d
Address PR #372 R10 review (3 P3) + rebase onto main
(Branch rebased onto origin/main first - 5 landed commits replayed cleanly,
zero file overlap with the docs-refresh changeset.)
P3 - HAD catalog one-liners omit panel-only restriction
- Both README.md L113 and diff_diff/guides/llms.txt L64 describe the
estimator without noting that the validator rejects repeated
cross-section inputs (per REGISTRY L2511-2512 and had.py
_validate_had_panel). Append "Panel-only in this release - repeated
cross-sections rejected by the validator" so practitioners with RCS
data are not misrouted.
P3 - api/had.rst inference contract under-specifies mass-point survey
vcov rejections
- Reviewer caught that the inference contract section says only HC2 /
HC2_BM are unsupported, but the shipped code also rejects
vcov_type="classical" on:
- design="mass_point" + survey= (static and event-study)
- design="mass_point" + weights= + aggregate="event_study" + cband=True
The HC1-scaled per-unit 2SLS IF would silently target V_HC1 under a
classical label.
- Add a paragraph to api/had.rst mirroring REGISTRY L2377-L2379 and
the front-door NotImplementedError messages at had.py L3360-3380 and
L4090-4115 (pointing users to vcov_type="hc1" or robust=True).
P3 - REGISTRY checklist disagrees with TODO.md on HAD Phase 5 status
- TODO.md L108 says the README catalog / llms.txt / API page /
references.rst portion of HAD Phase 5 landed in PR #372, but
REGISTRY L2531 still says "Phase 5: Tutorial notebook + llms.txt +
llms-full.txt updates" as one undone item.
- Split the REGISTRY checklist row: mark the PR #372 portion as [x]
with explicit scope (README catalog, bundled llms.txt, docs/api/had.rst,
docs/references.rst), keep the remaining tutorial + llms-full.txt
work as [ ].
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 916efc6 commit a21cd5d
4 files changed
Lines changed: 16 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
61 | 73 | | |
62 | 74 | | |
63 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2528 | 2528 | | |
2529 | 2529 | | |
2530 | 2530 | | |
2531 | | - | |
| 2531 | + | |
| 2532 | + | |
2532 | 2533 | | |
2533 | 2534 | | |
2534 | 2535 | | |
| |||
0 commit comments