Skip to content

Port R did package tests, fix not_yet_treated bugs #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igerber merged 2 commits into from
Mar 18, 2026
Merged

Port R did package tests, fix not_yet_treated bugs #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d4741
Port R `did` package tests and fix not_yet_treated control group bugs
igerber Mar 18, 2026
c8cd414
Address PR #207 review feedback: fix misleading control unit label an…
igerber Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,18 @@ Spurious RuntimeWarnings ("divide by zero", "overflow", "invalid value") are emi

---

## Feature Gaps (from R `did` package comparison)

Features in R's `did` package that block porting additional tests:

| Feature | R tests blocked | Priority |
|---------|----------------|----------|
| Repeated cross-sections (`panel=FALSE`) | ~7 tests in test-att_gt.R + test-user_bug_fixes.R | Medium |
| Sampling/population weights | 7 tests incl. all JEL replication | Medium |
| Calendar time aggregation | 1 test in test-att_gt.R | Low |

---

## Performance Optimizations

Potential future optimizations:
Expand Down
Loading
Loading