Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
42590aa
Add Phase 3 survey design support for 6 OLS-based estimators
igerber Mar 21, 2026
f823a7a
Fix 5 P1 issues from PR #226 review (round 1)
igerber Mar 21, 2026
a8a6d2c
Fix 4 P1 issues from PR #226 review (round 2)
igerber Mar 21, 2026
ce49f70
Fix weighted-mass IF linearization in ContinuousDiD and TripleDiffere…
igerber Mar 21, 2026
260728a
Fix ContinuousDiD bread normalization and panel-level survey metadata…
igerber Mar 21, 2026
719bfec
Fix EfficientDiD fweight consistency and BaconDecomposition index saf…
igerber Mar 21, 2026
e8fcf88
Fix ContinuousDiD fweight TSL scaling and BaconDecomposition empty-ce…
igerber Mar 21, 2026
9f4d538
Pass survey df to SunAbraham aggregate inference from PR #226 review …
igerber Mar 21, 2026
0c6748f
Add P3 regression tests: SunAbraham survey-df and DoseResponseCurve p…
igerber Mar 21, 2026
2ce3325
Fix BaconDecomposition exact-weight survey unit_share and add regress…
igerber Mar 22, 2026
f3d7427
Fix DoseResponseCurve survey df and strengthen P3 tests from PR #226 …
igerber Mar 22, 2026
4f04832
Reject EfficientDiD covariates + survey_design combination from PR #2…
igerber Mar 22, 2026
3c30f8e
Add survey test coverage for TripleDiff covariates and EfficientDiD a…
igerber Mar 22, 2026
08ab80f
Document EfficientDiD covariates+survey deferral in REGISTRY.md from …
igerber Mar 22, 2026
31a6962
Add within-unit survey validation to BaconDecomposition and regressio…
igerber Mar 22, 2026
8141b7c
Defer ContinuousDiD anticipation event-study filtering to TODO.md fro…
igerber Mar 22, 2026
ab38fac
Add survey resolution pattern inconsistency to TODO.md from PR #226 l…
igerber Mar 22, 2026
4604bad
Add duplicated survey summary formatting to TODO.md from PR #226 loca…
igerber Mar 22, 2026
cb2d885
Thread survey_design through bacon_decompose() and triple_difference(…
igerber Mar 22, 2026
efc09f9
Fix SunAbraham survey weight floor in overall ATT aggregation from PR…
igerber Mar 22, 2026
a8e2a20
Reject fweight for StackedDiD survey and add regression test from PR …
igerber Mar 22, 2026
5bdbcce
Fix TripleDifference RA nuisance linearization to include survey weig…
igerber Mar 22, 2026
ae7f687
Relax Bacon survey validation to exact-only and document fweight excl…
igerber Mar 22, 2026
e33ed3b
Also reject aweight for StackedDiD survey — only pweight supported fr…
igerber Mar 22, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ Deferred items from PR reviews that were not addressed before merge.
| EfficientDiD: API docs / tutorial page for new public estimator | `docs/` | #192 | Medium |
| Multi-absorb weighted demeaning needs iterative alternating projections for N > 1 absorbed FE with survey weights; unweighted multi-absorb also uses single-pass (pre-existing, exact only for balanced panels) | `estimators.py` | #218 | Medium |
| TripleDifference power: `generate_ddd_data` is a fixed 2×2×2 cross-sectional DGP — no multi-period or unbalanced-group support. Add a `generate_ddd_panel_data` for panel DDD power analysis. | `prep_dgp.py`, `power.py` | #208 | Low |
| ContinuousDiD event-study aggregation does not filter by `anticipation` — uses all (g,t) cells instead of anticipation-filtered subset; pre-existing in both survey and non-survey paths | `continuous_did.py` | #226 | Medium |
| Survey design resolution/collapse patterns are inconsistent across panel estimators — ContinuousDiD rebuilds unit-level design in SE code, EfficientDiD builds once in fit(), StackedDiD re-resolves on stacked data; extract shared helpers for panel-to-unit collapse, post-filter re-resolution, and metadata recomputation | `continuous_did.py`, `efficient_did.py`, `stacked_did.py` | #226 | Low |
| Duplicated survey metadata summary formatting across 6 results classes — extract shared `_format_survey_metadata(sm, width)` helper to reduce maintenance burden as more estimators gain survey support in Phases 4-5 | `results.py`, `stacked_did_results.py`, `sun_abraham.py`, `bacon.py`, `triple_diff.py`, `continuous_did_results.py`, `efficient_did_results.py` | #226 | Low |

#### Performance

Expand Down
Loading
Loading