Open
Conversation
GregDThomas
requested changes
Nov 3, 2024
Contributor
GregDThomas
left a comment
GregDThomas
left a comment
There was a problem hiding this comment.
A number of unrelated commits seem to have crept in with this one.
Also, by removing the @DaTa tag some of the classes have lost toString, dashcode and equals. In hindsight, at least one of those should have not have had the new password in the toString() (@ToString.Exclude), but a toString() method would be useful when checking logs.
src/main/java/org/jivesoftware/openfire/plugin/passwordreset/PasswordResetTokenManager.java
Show resolved
Hide resolved
src/main/java/org/jivesoftware/openfire/plugin/passwordreset/PasswordResetTokenManager.java
Show resolved
Hide resolved
...g/jivesoftware/openfire/plugin/passwordreset/servlet/admin/PasswordResetSettingsServlet.java
Show resolved
Hide resolved
...g/jivesoftware/openfire/plugin/passwordreset/servlet/admin/PasswordResetSettingsServlet.java
Show resolved
Hide resolved
Member
Author
|
@GregDThomas Sorry, I forgot to mention: I made the changes on top of the previous PR. SO in fact you may check only the last two commits. |
Member
Author
|
I added toString() to all DTOs with all fields except of passwords |
Contributor
|
OK - but the pipeline is failing with check style issues |
Member
Author
|
fixed, force pushed, build passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lombok on a such small codebase is not so helpful but makes build process more complicated.
The code reporting tools like Checkstyle and Spotbugs seems to report lines incorrectly.
I upgraded the Checkstyle to latest version that works on Java 8. Also the Spotbugs may be upgraded but... it then reports even more warnings that breaks a build.