-
Notifications
You must be signed in to change notification settings - Fork 48
Add template for documentation issues #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
021d0e9
to
be6ddfe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
- Coverage 74.2% 73.5% -0.7%
=======================================
Files 260 260
Lines 21818 21818
=======================================
- Hits 16198 16050 -148
- Misses 5620 5768 +148 🚀 New features to boost your workflow:
|
The two "failing" tests were at 99% successful and then were cancelled because of the timeout limit. Do we know why this happens? Our nightly CI also seems to run into this issue frequently of late. |
It looks like the tests get stuck in |
Thanks for this! My initial reaction is that the questions and/or explanatory text should be more direct and explicit about the kind of information people should give, in order to remind them what is appropriate. For example:
…could say something like:
I can make some edits later today, in this spirit.
If this is the case, and they pass on other OS, I would support to mark that one test |
Sounds good, thanks :) The tests do pass on both windows and ubuntu, so we can apply the skipif mark, though I don't exactly know the reason why it times out (but of course, we could say |
be6ddfe
to
b2da1cc
Compare
b2da1cc
to
c457680
Compare
Following up on today's discussion, I prepared an issue form/template based on the two existing documentation issues we already have:
Please note that I still enable blank issues because that's what we currently have and the only goal of this PR is to help with the creation of documentation issues.
How to review
I hope the file changes show a preview, otherwise, I'm not sure how we could check that everything renders properly. Maybe by merging this first to a fork and opening an issue there.
Yes: If you go to "Files changed" and select "View file" via the three dots on the form file, it will render as a form :)
PR checklist
Add or expand tests;coverage checks both ✅[ ] Add, expand, or update documentation.Not changing code.[ ] Update doc/whatsnew.Maybe just announce on Slack/during next weekly?