Skip to content

Conversation

yiyi1991
Copy link
Contributor

@yiyi1991 yiyi1991 commented Sep 22, 2025

This PR adds the documentation for the EFC projects.

How to review

  • Whether the efc.rst contains all research activities related to MESSAGEix model development,
  • makes sense to internal modelers,
  • and assigns the correct PL/PM.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@yiyi1991 yiyi1991 marked this pull request as ready for review September 22, 2025 14:37
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.8%. Comparing base (f580412) to head (3d28157).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #426     +/-   ##
=======================================
- Coverage   75.5%   74.8%   -0.7%     
=======================================
  Files        270     270             
  Lines      22093   22093             
=======================================
- Hits       16687   16539    -148     
- Misses      5406    5554    +148     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyi1991 thanks for this—especially for back-filling details about previous iterations/phases of the same project.

I made a few suggestions, see below. Once these are made and CI passes again, we can merge.

@khaeru khaeru added doc Improvements or additions to documentation enh New features or functionality labels Sep 22, 2025
@khaeru khaeru added this to the 2025-10 milestone Sep 22, 2025
@khaeru
Copy link
Member

khaeru commented Sep 22, 2025

Once these are made and CI passes again, we can merge.

I suppose we should also wait for ✅ from the 2 other requested reviewers, i.e. all 3 are needed.

@khaeru khaeru mentioned this pull request Sep 22, 2025
4 tasks
Copy link

@junukitashepard junukitashepard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small suggestion but otherwise looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation enh New features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants