-
Notifications
You must be signed in to change notification settings - Fork 48
Add doc for EFC projects #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
- Coverage 75.5% 74.8% -0.7%
=======================================
Files 270 270
Lines 22093 22093
=======================================
- Hits 16687 16539 -148
- Misses 5406 5554 +148 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiyi1991 thanks for this—especially for back-filling details about previous iterations/phases of the same project.
I made a few suggestions, see below. Once these are made and CI passes again, we can merge.
I suppose we should also wait for ✅ from the 2 other requested reviewers, i.e. all 3 are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small suggestion but otherwise looks good to me. Thanks!
This PR adds the documentation for the EFC projects.
How to review
PR checklist
Continuous integration checks all ✅Add or expand tests; coverage checks both ✅