Skip to content

fix(tests): sync docker-compose fixture with upstream templates (#1884)#1923

Closed
salarkhannn wants to merge 1 commit into
iii-hq:mainfrom
salarkhannn:fix/docker-compose-env-file
Closed

fix(tests): sync docker-compose fixture with upstream templates (#1884)#1923
salarkhannn wants to merge 1 commit into
iii-hq:mainfrom
salarkhannn:fix/docker-compose-env-file

Conversation

@salarkhannn

@salarkhannn salarkhannn commented Jun 30, 2026

Copy link
Copy Markdown

Sync the local test fixture with the canonical docker-compose template in iii-hq/templates, which already has env_file: .env (iii-hq/templates#33). The iii service was missing env_file: .env, so the engine container never received RABBITMQ_USER / RABBITMQ_PASS from the generated .env file at runtime.

Changes:

  • Add env_file: .env to the iii service in the docker-compose test fixture

  • Assert env_file: .env is present in both e2e tests that verify generated Docker assets

  • I license my contributions to this repository under Apache 2.0, and I have all necessary rights over the code I am contributing.

Closes #1884

Summary by CodeRabbit

  • Bug Fixes
    • Docker-based project setup now includes local .env variables in the iii container.
    • End-to-end checks were updated to confirm this behavior for both Docker initialization and Docker generation flows.

… env_file: .env

The canonical docker-compose template in iii-hq/templates already includes
env_file: .env so the iii container picks up RABBITMQ_USER and RABBITMQ_PASS
from the generated .env file. The test fixture was out of date.

Add the missing line and verify it in the two e2e tests that check generated
Docker assets.

Context: the fix for issue iii-hq#1884 lives in the runtime-fetched templates
(iii-hq/templates#33); this change brings the engine's local mirror and
test assertions in line so CI catches future drift.
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@salarkhannn is attempting to deploy a commit to the motia Team on Vercel.

A member of the Team first needs to authorize it.

@iii-hq-ci

iii-hq-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

License agreement recorded

@salarkhannn, your agreement has been recorded and you have been added to contributors.md. All future PRs from your account will pass this check automatically.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds env_file: .env to the iii service in the Docker Compose fixture template so the container loads environment variables from a local .env file. Two existing e2e tests are extended to read docker-compose.yml and assert the directive is present.

env_file directive and e2e coverage

Layer / File(s) Summary
docker-compose fixture and e2e assertions
engine/tests/fixtures/templates/docker/docker-compose.yml, engine/tests/project_init_e2e.rs
env_file: .env added to the iii service; both project init --docker and project generate-docker e2e tests now assert its presence in the generated docker-compose.yml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

  • iii-hq/iii#1607: Introduced the project init/project generate-docker flow and the docker-compose fixture that this PR extends with env_file: .env.

Suggested reviewers

  • anthonyiscoding

Poem

🐇 Hop hop, a dot-env in sight,
The iii container loads vars just right.
A fixture updated, a test made whole,
One line of YAML fills the missing role.
The rabbit cheers — env vars take flight! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change to sync the docker-compose fixture with upstream templates.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description includes the change, motivation, and reviewer notes, though it does not use the exact template headings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@guibeira guibeira self-requested a review June 30, 2026 11:49
@guibeira

Copy link
Copy Markdown
Contributor

Hey @salarkhannn , thanks for the contribution! This issue will be addressed in this PR: #1911

@salarkhannn

Copy link
Copy Markdown
Author

Closing as superseded — the fix for #1884 is already in main via #1911 ("Sync compose env_file fixture for generated Docker projects", merged 2026-06-30), which added both the env_file: .env line to the docker-compose fixture and the e2e assertions in project_init_e2e.rs. This branch was based on an older main that predated that merge, so its diff is fully covered. (Note: the PR description's reference to iii-hq/templates#33 is incorrect — the canonical change was iii-hq/templates#30.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated docker-compose .env not forwarded to engine; ${RABBITMQ_USER} unset at runtime

2 participants