fix(tests): sync docker-compose fixture with upstream templates (#1884)#1923
fix(tests): sync docker-compose fixture with upstream templates (#1884)#1923salarkhannn wants to merge 1 commit into
Conversation
… env_file: .env The canonical docker-compose template in iii-hq/templates already includes env_file: .env so the iii container picks up RABBITMQ_USER and RABBITMQ_PASS from the generated .env file. The test fixture was out of date. Add the missing line and verify it in the two e2e tests that check generated Docker assets. Context: the fix for issue iii-hq#1884 lives in the runtime-fetched templates (iii-hq/templates#33); this change brings the engine's local mirror and test assertions in line so CI catches future drift.
|
@salarkhannn is attempting to deploy a commit to the motia Team on Vercel. A member of the Team first needs to authorize it. |
License agreement recorded@salarkhannn, your agreement has been recorded and you have been added to contributors.md. All future PRs from your account will pass this check automatically. |
📝 WalkthroughWalkthroughAdds env_file directive and e2e coverage
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @salarkhannn , thanks for the contribution! This issue will be addressed in this PR: #1911 |
|
Closing as superseded — the fix for #1884 is already in |
Sync the local test fixture with the canonical docker-compose template in iii-hq/templates, which already has
env_file: .env(iii-hq/templates#33). Theiiiservice was missingenv_file: .env, so the engine container never receivedRABBITMQ_USER/RABBITMQ_PASSfrom the generated.envfile at runtime.Changes:
Add
env_file: .envto theiiiservice in the docker-compose test fixtureAssert
env_file: .envis present in both e2e tests that verify generated Docker assetsI license my contributions to this repository under Apache 2.0, and I have all necessary rights over the code I am contributing.
Closes #1884
Summary by CodeRabbit
.envvariables in theiiicontainer.