Skip to content

(MOT-3875) feat: routed provider family + freeform apply_patch custom tool#416

Closed
ytallo wants to merge 1 commit into
feat/shell-post-write-checksfrom
feat/edit-fidelity
Closed

(MOT-3875) feat: routed provider family + freeform apply_patch custom tool#416
ytallo wants to merge 1 commit into
feat/shell-post-write-checksfrom
feat/edit-fidelity

Conversation

@ytallo

@ytallo ytallo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
  • harness: a send (or parentless spawn) that omits provider resolves it
    from the router's model catalog before options freeze, so prompt-family
    selection and routing agree — headless codex sends now get the
    apply_patch code identity without passing provider explicitly. Router
    unreachable → warn and fall back to the previous default-family
    behavior.
  • provider-openai-codex: coder::apply-patch travels as a freeform custom
    tool named exactly apply_patch — the trained name and shape. The wire
    emits { type: custom }, and the SSE state machine accumulates
    custom_tool_call raw input (delta + authoritative done) into
    { patch: }, so patches cross the wire with no JSON escaping.
    Harness and shell still see an ordinary coder::apply-patch call.

Refs MOT-3875

…atch

- harness: a send (or parentless spawn) that omits provider resolves it
  from the router's model catalog before options freeze, so prompt-family
  selection and routing agree — headless codex sends now get the
  apply_patch code identity without passing provider explicitly. Router
  unreachable → warn and fall back to the previous default-family
  behavior.
- provider-openai-codex: coder::apply-patch travels as a freeform custom
  tool named exactly apply_patch — the trained name and shape. The wire
  emits { type: custom }, and the SSE state machine accumulates
  custom_tool_call raw input (delta + authoritative done) into
  { patch: <raw text> }, so patches cross the wire with no JSON escaping.
  Harness and shell still see an ordinary coder::apply-patch call.
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jul 6, 2026 11:41am
workers-tech-spec Ready Ready Preview, Comment Jul 6, 2026 11:41am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c39e6430-7ec7-45c4-b73c-f9f0caf51bb8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/edit-fidelity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 32 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo

ytallo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #423.

@ytallo ytallo closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant