Skip to content

(MOT-4101) fix(console): show function-call params the UI was dropping#530

Draft
ytallo wants to merge 1 commit into
mainfrom
fix/mot-4101-console-fcall-params
Draft

(MOT-4101) fix(console): show function-call params the UI was dropping#530
ytallo wants to merge 1 commit into
mainfrom
fix/mot-4101-console-fcall-params

Conversation

@ytallo

@ytallo ytallo commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve executed function-call arguments across wrapper unwrapping, approval updates, and degraded transcript snapshots.
  • Fall back to the raw request pane when a specialized tool preview cannot parse the request.
  • Add regression coverage for flattened and stringified payloads, snapshot preservation, empty-input detection, and shell preview fallbacks.

Why

The console could show request · empty, or no arguments at all for a held call, even though the backend executed the call with full arguments. Transcript mapping dropped some wrapper payload shapes, and preview renderers could suppress the raw-request fallback before confirming that they had a renderable request.

Impact

Function-call cards now keep reviewable arguments visible and accurately reflect what was executed, including calls waiting for approval.

Validation

  • pnpm test -- src/lib/sessions/entry-mapper.test.ts src/components/chat/shell/__tests__/preview-contract.test.ts (79 files, 1,036 tests passed)
  • pnpm typecheck
  • Biome check on all 11 changed files

The repository-wide lint command still reports pre-existing issues in files outside this diff.

Fixes MOT-4101

A call could execute with full arguments while its chat card showed "request · empty", or no arguments at all for a held shell command.

Mirror the harness wrapper-unwrapping behavior in transcript mapping, preserve populated input across degraded snapshots, backfill arguments from approval records, and make preview renderers honor the raw-request fallback contract.

Add regression coverage for flattened and stringified wrapper payloads, snapshot preservation, empty-input detection, and shell preview fallbacks.
@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jul 18, 2026 9:07pm
workers-tech-spec Ready Ready Preview, Comment Jul 18, 2026 9:07pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 46 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 912f2c8f-5bf9-46ff-b41b-214182ac9d16

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mot-4101-console-fcall-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant