(MOT-4101) fix(console): show function-call params the UI was dropping#530
(MOT-4101) fix(console): show function-call params the UI was dropping#530ytallo wants to merge 1 commit into
Conversation
A call could execute with full arguments while its chat card showed "request · empty", or no arguments at all for a held shell command. Mirror the harness wrapper-unwrapping behavior in transcript mapping, preserve populated input across degraded snapshots, backfill arguments from approval records, and make preview renderers honor the raw-request fallback contract. Add regression coverage for flattened and stringified wrapper payloads, snapshot preservation, empty-input detection, and shell preview fallbacks.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 46 skipped (no docs/).
Four for four. Nicely done. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Why
The console could show
request · empty, or no arguments at all for a held call, even though the backend executed the call with full arguments. Transcript mapping dropped some wrapper payload shapes, and preview renderers could suppress the raw-request fallback before confirming that they had a renderable request.Impact
Function-call cards now keep reviewable arguments visible and accurately reflect what was executed, including calls waiting for approval.
Validation
pnpm test -- src/lib/sessions/entry-mapper.test.ts src/components/chat/shell/__tests__/preview-contract.test.ts(79 files, 1,036 tests passed)pnpm typecheckThe repository-wide lint command still reports pre-existing issues in files outside this diff.
Fixes MOT-4101