Skip to content

(MOT-4235) fix(harness): use row-changed trigger name - #618

Merged
andersonleal merged 1 commit into
mainfrom
fix/harness-row-changed-trigger
Jul 28, 2026
Merged

(MOT-4235) fix(harness): use row-changed trigger name#618
andersonleal merged 1 commit into
mainfrom
fix/harness-row-changed-trigger

Conversation

@andersonleal

@andersonleal andersonleal commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • align the Harness E2E stack readiness check with database::row-changed
  • update the reactive automation prompt, evidence matcher, and documentation to use the registered trigger name

Root cause

The database worker changed its trigger type from database::row-change to database::row-changed in #614, but the separate Harness E2E suite retained the old name. Its shared startup check waited 60 seconds for a trigger that would never register, so every scenario failed before execution.

Validation

  • cargo test -p harness-e2e — 41 passed
  • cargo fmt --all -- --check
  • bash -n harness/tests/e2e/run-ci.sh
  • git diff --check

Refs MOT-4235

Summary by CodeRabbit

  • Bug Fixes

    • Corrected database trigger event handling in the reactive automation scenario.
    • Improved synchronization and trigger discovery during end-to-end test execution.
  • Documentation

    • Updated scenario documentation and prompts to reflect the correct database trigger event name.
  • Tests

    • Ensured evidence collection and service startup checks recognize the updated trigger event.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jul 28, 2026 9:09pm
workers-tech-spec Ready Ready Preview, Comment Jul 28, 2026 9:09pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba18d01a-53ba-4983-b932-5f2c2e3c9985

📥 Commits

Reviewing files that changed from the base of the PR and between f921741 and 0e0ee84.

📒 Files selected for processing (4)
  • harness/tests/e2e/README.md
  • harness/tests/e2e/run-ci.sh
  • harness/tests/e2e/src/scenarios/reactive_automation/prompt.rs
  • harness/tests/e2e/src/scenarios/reactive_automation/queries.rs

📝 Walkthrough

Walkthrough

The reactive automation e2e harness, prompt, evidence query, and README now consistently reference database::row-changed instead of database::row-change.

Changes

Reactive automation trigger updates

Layer / File(s) Summary
Align reactive automation trigger identifier
harness/tests/e2e/run-ci.sh, harness/tests/e2e/src/scenarios/reactive_automation/*, harness/tests/e2e/README.md
The CI wait, prompt probe, evidence matching logic, and documented function path now use database::row-changed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • iii-hq/workers#614: Updates the implementation and event delivery for the database::row-changed trigger.

Suggested reviewers: ytallo

Poem

A bunny finds a trigger bright,
row-changed hops into sight.
The harness waits, the probes agree,
Queries match in harmony.
E2E paws now land just right!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/harness-row-changed-trigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 49 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@andersonleal
andersonleal marked this pull request as ready for review July 28, 2026 21:12
@andersonleal
andersonleal merged commit 9e4649c into main Jul 28, 2026
15 of 16 checks passed
@andersonleal
andersonleal deleted the fix/harness-row-changed-trigger branch July 28, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant