Trim code and stop tracking generated data - #6
Merged
Merged
Conversation
…rom git
- index.ts: derive findState/City/County/Coordinates from find(); share filterBy
- rollup: merge ESM+CJS configs, drop json plugin and default options
- package.json: remove check-data, postinstall, build:types scripts
- untrack generated data/zip-data.{js,d.ts}; regenerated in prebuild
- data/US.txt: move zip 89044 from Lincoln to Clark county
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rt missing zip-data.js Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
index.ts:findState/City/County/Coordinatesnow derive fromfind();findByCity/Countyshare onefilterByhelper; removed redundant regex/normalize step (~100 lines fewer)rollup.config.js: ESM + CJS builds merged; removed unusedjsonplugin and default optionspackage.json: removedcheck-data,postinstall,build:types, and@rollup/plugin-json;prebuildnow always runsprocess-datadata/zip-data.js/.d.ts(gitignored, regenerated byprebuildvianpm ci→prepare)data/US.txt: zip 89044 moved from Lincoln to Clark CountyVerification
npm run buildsucceeds; 28/28 tests pass locallyTo check
npm cirunningprepareto generatezip-data.jsbeforenpm testdist/index.d.tsis still emitted by the rollup typescript plugin after removingbuild:types🤖 Generated with Claude Code