Fix gRPC logger to log structured fields #141
Open
+352
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriSweedler
reviewed
Feb 28, 2025
AriSweedler
reviewed
Feb 28, 2025
Reimplement gRPC logger as a Zap Core wrapper instead of a hook, so it can log the structure log fields. Replace SugaredLogger with Logger in all the codebase to improve efficience and eliminate formatting bugs.
Encode each entry into a string immediately when logged, before buffering, and never refer to the input Entry and Fields afterwards, as it is more compact and it allows the fields to be garbage-collected while the log entry is buffered.
rlenglet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SugaredLoggerwithLoggerin the whole codebase to improve efficiency and eliminate formatting bugs.