Avoid trait bounds on structs when possible #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having trait bounds on the structs' implementations suffices.
197g
approved these changes
Nov 25, 2025
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
ZipFile is unfortunately from a viral bound in zip::ZipFile which we can't get rid of here (at least not in safe code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having trait bounds on the structs' implementations suffices.
For context, see #16 (comment).
Note:
PCXDecoderstill requiresReadforpcx::Reader; I haven't figured out how to remove the trait bounds forOpenRasterDecoder, for which ZipFile requiresRead.