fix: Command cannot be executed on Windows #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces platform-specific adjustments to the
ICommandShell
class within theJennifer::Adapter
module. These changes ensure compatibility with both Windows and Unix-like systems by conditionally modifying command execution behavior and related constants.Changes Made
Platform-Specific Constants:
OPTIONS_PLACEHOLDER
is now conditionally set based on the operating system. For Windows (win32
), it is an empty string, while for other systems, it remains as%("${@}")
.SUDO
is conditionally set to an empty string for Windows and"sudo"
for Unix-like systems.Command Execution Logic:
invoke
method now uses platform-specific logic to execute commands. On Windows, it usescmd /c
to run the command, whereas on Unix-like systems, it uses the shell directly.Testing
cmd /c
.Notes