added unsigned int support #462
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows you to define models with unsigned integer fields presuming that the underlying adapter supports it. This also adds
Array(8)because it looked like it was missing previously.Any background context you want to provide?
I added support for these datatypes for sqlite in this pr: crystal-lang/crystal-sqlite3#98. There may be changes made in crystal-db to add support more generally which might be relevant. Locally I'm using UInt16 and Int16, and it seems to be working for my application using my forked versions with sqlite.
Release notes
Model
Adds potential support for Unsigned Integers (8, 16, 32, 64) and also Array(Int8)
Adapter
Adds potential support for Unsigned Integers (8, 16, 32, 64) and also Array(Int8)