Optimize spatial module - #24
Draft
elevans wants to merge 21 commits into
Draft
Conversation
Instead of defining point "i" is outside of face "f", we can save compute time by finding the furthest face from point "i" instead.
elevans
force-pushed
the
optimize-spatial-module
branch
from
July 22, 2026 17:04
c3bbee9 to
29c4b9e
Compare
Oops how did that get there??
array::from_fn() is convient but it makes it harder for the compiler to autovectorize this.
This avoid unnecessary repeated calculations.
This saves a double call to orient_pred_3d.
This makes finding pc and pd parallelizable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings various performance optimizations to the
spatialmodule and it's functions.