Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google OAuth 2.0 Passport strategy. #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Google OAuth 2.0 Passport strategy. #159

wants to merge 1 commit into from

Conversation

eraviart
Copy link
Contributor

@eraviart eraviart commented Nov 5, 2016

No description provided.

@impronunciable
Copy link
Owner

Thank you!
I'll review this during the weekend

On Sat, Nov 5, 2016, 1:43 AM eraviart [email protected] wrote:

You can view, comment on, or merge this pull request online at:

#159
Commit Summary

  • Add Google OAuth 2.0 Passport strategy.

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#159, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKHp6m-DUk0NZpwflDD_-LdA5CIXVbiks5q69EZgaJpZM4KqHST
.

@eraviart
Copy link
Contributor Author

eraviart commented Nov 5, 2016

This pull request is obsoleted by #161 but I keep it if you only want Google authentication without Auth0 authentication.

clkao
clkao reviewed Dec 30, 2016
View reviewed changes
lib/auth/index.js
@@ -71,13 +71,15 @@ const setPicture = (user, profile) => {
*/

const generateStrategy = provider => {
// Geneate routes
// Generate routes
const options = provider === 'google' ? { scope: ['profile'] } : {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably require 'email' scope in addition to profile, because we are trusting the user's email input without verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clkao clkao clkao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eraviart @impronunciable @clkao