Skip to content

Support blueprintUE embedding #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Conversation

tsuzuki-takaaki
Copy link
Contributor

@tsuzuki-takaaki tsuzuki-takaaki commented Jul 15, 2025

What

  • Support blueprintUE embedding
  • Add blueprintue.com to iframe src white list

blueprintUE's embed URL is like this:

<iframe src="https://blueprintue.com/render/67k4gbg5/" scrolling="no" allowfullscreen></iframe>

Ref

@tsuzuki-takaaki tsuzuki-takaaki self-assigned this Jul 15, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tsuzuki-takaaki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new functionality to allow embedding content from blueprintue.com within Qiita Markdown. This involves whitelisting blueprintue.com as a trusted source for iframes and integrating a new module to manage its specific embedding details, ensuring safe and proper rendering.

Highlights

  • New Embedding Support: I've added support for embedding content from blueprintue.com within Qiita Markdown, expanding the range of external content that can be safely displayed.
  • Dedicated Embed Module: A new module, Qiita::Markdown::Embed::BlueprintUe, has been introduced to specifically manage the blueprintue.com script host, following the existing pattern for other embed types.
  • Iframe Whitelisting: The FilterIframe transformer has been updated to explicitly allow iframes originating from blueprintue.com, ensuring they are not stripped or modified during markdown processing.
  • Comprehensive Testing: New RSpec tests have been added to processor_spec.rb to verify that blueprintUE embeds are correctly processed and displayed, covering scenarios with and without explicit URL schemes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for embedding content from blueprintUE via iframes. The changes are well-structured and follow the existing patterns in the codebase for other embeddable content. The core logic for whitelisting the new host and the accompanying tests are correctly implemented.

<iframe src="#{url}" width="800" height="600" frameborder="0" allowfullscreen="true"></iframe>
MARKDOWN
end
let(:url) { "#{scheme}//blueprintue.com/embed/example" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The domain blueprintue.com is hardcoded here. To improve maintainability and prevent potential inconsistencies, it's better to use the Qiita::Markdown::Embed::BlueprintUe::SCRIPT_HOST constant defined for this purpose.

let(:url) { "#{scheme}//#{Qiita::Markdown::Embed::BlueprintUe::SCRIPT_HOST}/embed/example" }

@tsuzuki-takaaki tsuzuki-takaaki marked this pull request as ready for review July 15, 2025 06:53
@tsuzuki-takaaki tsuzuki-takaaki requested review from a team and ohakutsu and removed request for a team July 15, 2025 06:57
@P-SiZK P-SiZK requested review from P-SiZK and removed request for ohakutsu July 16, 2025 02:01
Copy link
Contributor

@P-SiZK P-SiZK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsuzuki-takaaki tsuzuki-takaaki merged commit 7f54b28 into master Jul 16, 2025
8 checks passed
@tsuzuki-takaaki tsuzuki-takaaki deleted the support-blueprintue-embedding branch July 16, 2025 03:56
@tsuzuki-takaaki tsuzuki-takaaki mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants