Add method to skip wrong reference format #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observation
When an image reference format is wrong, the mutating webhook is failing and the deployment cannot go further. Even if the regex does not include this image.
I think that it should be great to skip that case and let the mutating webhook deploies this deployment anyway.
I detected that in a case where ArgoCD + Image updater need to deploy a pod without tag before finding / applying a new tag. So without this the ArgoCD deployments could be broken
Solution
Add a method to verify the reference format, if it's wrong, just skip the mutating webhook changes and return the same imageRef
Tests