-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url change, new endpoint to plant_list and more timespan options #65
base: master
Are you sure you want to change the base?
Conversation
date_str = date.strftime('%Y-%m-%d') | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reorder the if statement to have %Y at the top, %Y-%m after the and %Y-%m-%d at the bottom? Helps with reading through the code faster 🙂
|
||
class GrowattApi: | ||
server_url = 'https://server-api.growatt.com/' | ||
server_url = 'https://server.growatt.com/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server-api.growatt.com is still the URL being used by the app, as not everyone is having issues with the current URL and the new URL might respond differently.
It could cause issues in currently running code.
It's best to overwrite this URL in the scripts using it
server_url = 'https://server.growatt.com/' | |
server_url = 'https://server-api.growatt.com/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outdated, see #77
server_url change, same as pr #62
endpoint for plant_detail changed from
PlantDetailAPI
tonewPlantDetailAPI
, retrieving complete date on data dictadded 2 more timespan options,
year
andall