Custom resources for loading menu titles and information, as well as loading menu visuals and images by alfvy · Pull Request #31 · infernoplus/JortPob

alfvy · 2026-01-14T22:24:37Z

these are pretty simple, since there's already ways to write custom param rows, meaning that there can be more than what came with the base game,

as well as writing to the hi/solo and low/solo files in the icon manager, but those are limited to 34 as far I know

…f_parser

…s and information, and loading menu visuals

horfius · 2026-01-14T23:47:36Z

I don't really want to review this PR until your other one is merged @alfvy as it has significant overlap and is a bit confusing which pieces are new to this PR.

horfius

A few cleanup bits, some clarifications, and a few dangerous code smells. Getting #28 merged first would help clarify what changes are new and which are carried over from that branch.

horfius · 2026-01-20T20:47:01Z

JortPob/TextManager.cs

            }

-            menu = LoadMsgBnd(Utility.ResourcePath(@"text\menu_dlc02.msgbnd.dcx"));
+            menu = LoadMsgBnd($"{Const.ELDEN_PATH}Game\\msg\\engus\\menu.msgbnd.dcx");


Use Path.Combine and @.

horfius · 2026-01-20T20:47:23Z

JortPob/TextManager.cs

        public int AddChoice(string text)
        {
-            foreach(FMG.Entry entry in menu[TextType.EventTextForTalk].Entries)
+            foreach(FMG.Entry entry in menuDlc[TextType.EventTextForTalk].Entries)


Can be simplified with .First

And the other functions in the file doing the same pattern should also use First instead of foreach.

horfius · 2026-01-20T20:48:09Z

JortPob/TextManager.cs

        {
            int id = nextMenuId++;
-            FMG fmg = menu[TextType.GR_MenuText];
+            FMG fmg = menuDlc[TextType.GR_MenuText];


Just do menuDlc[TextType.GR_MenuText].entries.Add(...) instead of having the fmg variable.

JortPob/Paramanager.cs

horfius · 2026-01-20T22:50:38Z

JortPob/MenuTextureManager.cs

+            (var hiBxf, var lowBxf) = icon.Write();
+            images.Write(hiBxf, lowBxf);
+
+            hiBxf.Write($"{Const.OUTPUT_PATH}menu\\hi\\00_solo.tpfbhd", $"{Const.OUTPUT_PATH}menu\\hi\\00_solo.tpfbdt");


Path.Combine and @. With the amount that Path joins are done with OUTPUT_PATH, it might be worth creating a helper method to reduce duplication in case we need to change any formatting in the future.

horfius · 2026-01-20T23:17:59Z

JortPob/LoadingImagesManager.cs

+                var tpf = new TPF();
+                var texture = new TPF.Texture();
+
+                var fileName = file.Name.Split('.')[0].Split('\\')[1];


Would Path.GetFileName work here or are there multiple periods before the extension? If there are multiple path separators I think this would include everything after the first one.

this is the path pulled directly from the bxf, its not a standard path, and has some internal engine shenanigans associated

horfius · 2026-01-21T20:08:31Z

JortPob/LoadingImagesManager.cs

+                .Where(f => f.Name.ToLower().Contains("menu_load") && !f.Name.ToLower().Contains("ps5"))
+                .ToList();
+
+            foreach (var file in lowFiles)


Since this logic is exactly the same as above just with lowFiles instead of hiFiles, I suggest moving the logic to a private helper function to reduce duplication.

horfius · 2026-01-21T20:11:02Z

JortPob/IconManager.cs

+            return (hiBxf, lowBxf);
+        }
+
+        public void Dispose()


if IconInfo or BuffInfo aren't actually disposable types then there isn't benefit to implementing IDisposable here. Counterintuitively, setting collections to null can sometimes delay their GC cleanup due to funky .NET things.

I have 0 idea how either works tbh, if they're made to be disposable, then disposable they are

horfius · 2026-01-21T20:11:57Z

JortPob/IconManager.cs

    {
-        public readonly List<IconInfo> icons;
-        public readonly List<BuffInfo> buffs;
+        public List<IconInfo> icons { get; private set; }


Should use init instead of private set if these are still just being initialized in the constructor.

horfius · 2026-01-21T20:13:16Z

JortPob/Common/Utility.cs

+            }
+        }
+
+        // source: trust me bro


Can you provide a source for this? Not that I don't trust you, but we aren't actually running a game so using the slower, but more accurate, power methods is likely preferable.

The accuracy difference is about 1 in 4 thousand decimal places, so very very tiny, and it's an almost 20x speed up, this is my source: https://martin.ankerl.com/2007/10/04/optimized-pow-approximation-for-java-and-c-c/

All good, just wondering what dark magic you were incanting.

horfius

This looks much cleaner than before. Only one actual error I can see although some of the other cleanup would be nice, but optional.

horfius · 2026-01-25T20:04:31Z

JortPob/TextManager.cs

+            loadingTitleFmg.Entries.Clear();
+            loadingTextFmg.Entries.Clear();
+
+            int id = 1;


You forgot to increment this per loop.

alfvy and others added 4 commits December 17, 2025 00:15

Merge branch 'nif_parser' of https://github.com/alfvy/JortPob into ni…

983e0d6

…f_parser

attempting to load new loading menu titles and info

3d8bf17

Added loading menu resources in the form of custom loading menu title…

2d315a5

…s and information, and loading menu visuals

Merge branch 'main' into loading-menu-res

8bc7a9e

horfius requested changes Jan 21, 2026

View reviewed changes

alfvy and others added 2 commits January 25, 2026 20:30

optimizations and merge fixes

b8d7c95

Merge branch 'main' into loading-menu-res

776273a

horfius requested changes Jan 25, 2026

View reviewed changes

hotfix

258ef33

infernoplus closed this Feb 27, 2026

Conversation

alfvy commented Jan 14, 2026

Uh oh!

horfius commented Jan 14, 2026

Uh oh!

horfius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

horfius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants