Repository navigation
fix: guarantee first-line text headroom so post headings are not clipped - #81
Closed
IamNewHands wants to merge 1 commit into
Closed
IamNewHands wants to merge 1 commit into
IamNewHands wants to merge 1 commit into
Conversation
iOS 17+ .oversize can draw a paragraph's first line above the container origin while CoreText reports no ascent overflow, so a small fixed guard lets some post/reply headings lose their top pixels. Always measure the first line's glyph ink, floor the top inset at 3pt, and reserve the negative usedRect.minY extent in the measured height so the heading of a post or reply can never be clipped. Update the smoke test accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS 17+ .oversize can draw a paragraph's first line above the container origin while CoreText reports no ascent overflow, so a small fixed guard lets some post/reply headings lose their top pixels. Always measure the first line's glyph ink, floor the top inset at 3pt, and reserve the negative usedRect.minY extent in the measured height so the heading of a post or reply can never be clipped. Update the smoke test accordingly.