Repository navigation
feat: home tab gestures — single returns to root, double scrolls top,… - #82
Closed
IamNewHands wants to merge 1 commit into
Closed
IamNewHands wants to merge 1 commit into
IamNewHands wants to merge 1 commit into
Conversation
… long-press refreshes Split Home reselect into discernible intents driven by gesture recognizers on the tab bar: single tap collapses detail/search back to the feed root, double tap additionally scrolls to top (no refresh), long press refreshes the feed. HomeView now observes three tokens (returnToRoot/scrollToTop/ refresh) instead of a single reselect token. Update HomeNavigationTests and the home-tab UI tests to the new gestures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… long-press refreshes
Split Home reselect into discernible intents driven by gesture recognizers on the tab bar: single tap collapses detail/search back to the feed root, double tap additionally scrolls to top (no refresh), long press refreshes the feed. HomeView now observes three tokens (returnToRoot/scrollToTop/ refresh) instead of a single reselect token. Update HomeNavigationTests and the home-tab UI tests to the new gestures.