fix(version-detector): centralize Grafana links and DRY up host examples #6693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… URLs Refactor handleAuthorizationHelp to use getGrafanaLink() instead of hardcoded URLs, ensuring all Grafana links come from a single source. Also fix incorrect URLs in getGrafanaLink mapping: - InfluxDB OSS 2.x: /visualize-data/ → /tools/ - InfluxDB Enterprise: /influxdb/enterprise/ → /enterprise_influxdb/v1/ - InfluxDB Cloud (TSM): /visualize-data/ → /tools/ - InfluxDB Cloud v1: now links to Enterprise v1 docs (Cloud v1 is Enterprise under the hood)
Extract HOST_EXAMPLES to a class-level constant and add DEFAULT_HOST and DEFAULT_HOST_PORT constants to eliminate duplicate localhost:8086 strings throughout the code. - Move hostExamples from local variable to class constant - Use DEFAULT_HOST for URL placeholder and comparison checks - Use DEFAULT_HOST_PORT for docker curl command examples
Contributor
PR PreviewPreview pages neededThis PR changes layout/asset files but doesn't specify which pages to preview. To generate a preview, add documentation URLs to your PR description, for example: Then re-run the workflow or push a new commit. Last checked: 2026-01-03 20:09:25 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
handleAuthorizationHelpto usegetGrafanaLink()instead of hardcoded URLs, ensuring all Grafana links come from a single sourcegetGrafanaLinkmapping (v2, Enterprise, Cloud TSM, Cloud v1)HOST_EXAMPLESto a class-level constant and addDEFAULT_HOST/DEFAULT_HOST_PORTconstants to eliminate duplicatelocalhost:8086stringsTest plan