feat: Minor improvements to error visibility #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
backoff-log-source
branch
from
f4e50d6
to
76a22c7
Compare
crepererum
reviewed
Jan 23, 2024
src/connection.rs
Outdated
| // errors should always contain at least 1 element here. | ||
| let errors_string = errors | ||
| .into_iter() | ||
| .map(|e| e.to_string()) |
There was a problem hiding this comment.
I suggest you create a helper type here to delay the error formatting until it is actually needed:
struct MultiError(Vec<Box<dyn std::error::Error + Send + Sync>);
impl std::error::Error for MultiError {...}There was a problem hiding this comment.
Sure, that's probably better. Maybe it would even be more useful with
struct MultiError<T: std::error::Error + Send + Sync + 'static>(Vec<T>)
There was a problem hiding this comment.
Though since we're sticking it in a Box<dyn ...> anyway I guess it doesn't make much of a difference in this case.
einarmo
force-pushed
the
backoff-log-source
branch
from
76a22c7
to
9b70a52
Compare
crepererum
changed the title
|
tests need a fix and the commit message shall follow Conventional Commits (just prefix it with |
einarmo
force-pushed
the
backoff-log-source
branch
from
9b70a52
to
0fa23f0
Compare
This commit also removes a few unhelpful comments that are no longer correct.
einarmo
force-pushed
the
backoff-log-source
branch
from
0fa23f0
to
d121e81
Compare
|
I have three separate commits, as they are technically three separate changes, but I'll squash them if you prefer. Also, I think technically they are features, since they are visible to users. |
einarmo
changed the title
einarmo
force-pushed
the
backoff-log-source
branch
from
d121e81
to
badfe9d
Compare
crepererum
approved these changes
Feb 6, 2024
|
Thank you and sorry for the review delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few small changes:
BackoffErrorto also include thesourceerror.connection::ErrorasConnectionError. Currently it is not visible at all, sinceconnectionis a private module.Nothing should be breaking or particularly intrusive.