feat(inputs.socket_listener): Add SSM/IGMPv3 support#18915
Conversation
…urce option Signed-off-by: maxcillius <alphaviperchamber@hotmail.com>
|
Thanks so much for the pull request! |
|
!signed-cla |
srebhan
left a comment
There was a problem hiding this comment.
Thanks @Maxcillius for your contribution! I do have some comments in the code. Furthermore, please run make docs in Telegraf's project root to update the README.md file after modifying sample.conf.
Signed-off-by: maxcillius <alphaviperchamber@hotmail.com>
|
you are right in addressing those. I have updated the code. |
…ple config Signed-off-by: maxcillius <alphaviperchamber@hotmail.com>
|
@Maxcillius can you please run |
… multicast_source Signed-off-by: maxcillius <alphaviperchamber@hotmail.com>
srebhan
left a comment
There was a problem hiding this comment.
@Maxcillius one more thing to make the linter happy. It might be necessary to run make fmt after that change...
| } | ||
|
|
||
| func newPacketListener(encoding string, maxDecompressionSize config.Size, maxWorkers int, allowedSources []net.IP, logger telegraf.Logger) *packetListener { | ||
| func newPacketListener(encoding string, maxDecompressionSize config.Size, maxWorkers int, allowedSources []net.IP, multicastSource string, logger telegraf.Logger) *packetListener { |
There was a problem hiding this comment.
Please wrap the parameter list to make the linter happy. I think in the long run we should kick this function and fill the struct directly instead. But that's for another PR...
| func newPacketListener(encoding string, maxDecompressionSize config.Size, maxWorkers int, allowedSources []net.IP, multicastSource string, logger telegraf.Logger) *packetListener { | |
| func newPacketListener( | |
| encoding string, | |
| maxDecompressionSize config.Size, | |
| maxWorkers int, | |
| allowedSources []net.IP, | |
| multicastSource string, | |
| logger telegraf.Logger, | |
| ) *packetListener { |
Signed-off-by: maxcillius <alphaviperchamber@hotmail.com>
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
Added feature in socket_listener for source specific multicast.
Related issues
resolves #18581