Skip to content

feat(parsers.graphite): Implement ParserTimeFuncPlugin interface #18948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skartikey merged 2 commits into from
May 29, 2026
+10 −1
Merged

feat(parsers.graphite): Implement ParserTimeFuncPlugin interface #18948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8942444
feat(parsers.graphite): Implement ParserTimeFuncPlugin interface
srebhan May 20, 2026
e56d31b
Restore time parsing precision
srebhan May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion plugins/parsers/graphite/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type Parser struct {
DefaultTags map[string]string ` toml:"-"`

templateEngine *templating.Engine
timeFunc func() time.Time
}

func (p *Parser) Init() error {
Expand All @@ -45,9 +46,17 @@ func (p *Parser) Init() error {
return fmt.Errorf("creating template engine failed: %w ", err)
}

if p.timeFunc == nil {
p.timeFunc = time.Now
}

return nil
}

func (p *Parser) SetTimeFunc(fn func() time.Time) {
p.timeFunc = fn
}

func (p *Parser) Parse(buf []byte) ([]telegraf.Metric, error) {
// parse even if the buffer begins with a newline
if len(buf) != 0 && buf[0] == '\n' {
Expand Down Expand Up @@ -119,7 +128,7 @@ func (p *Parser) ParseLine(line string) (telegraf.Metric, error) {
}

// If no 3rd field, use now as timestamp
timestamp := time.Now().UTC()
timestamp := p.timeFunc()

if len(fields) == 3 {
// Parse timestamp.
Expand Down
Loading