Skip to content

chore(parsers.grok): Cleanup code#18949

Open
srebhan wants to merge 1 commit into
influxdata:masterfrom
srebhan:parser_grok
Open

chore(parsers.grok): Cleanup code#18949
srebhan wants to merge 1 commit into
influxdata:masterfrom
srebhan:parser_grok

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented May 20, 2026

Summary

Cleanup the code.

Checklist

Related issues

@telegraf-tiger telegraf-tiger Bot added chore plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels May 20, 2026
@telegraf-tiger
Copy link
Copy Markdown
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 20, 2026
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks! Just one comment.

p.Patterns = []string{"%{COMBINED_LOG_FORMAT}"}
}

if p.UniqueTimestamp == "" {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Init() now has the same if p.UniqueTimestamp == "" { p.UniqueTimestamp = "auto" } block twice (with the other defaults, then again after the grok constructor). The second block can be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants