feat(mqtt output): add ws:// and wss:// scheme support#18958
Open
aitorhh wants to merge 1 commit into
Open
Conversation
The MQTT output plugin now supports WebSocket connections by preserving ws:// and wss:// URL schemes instead of overriding them to tls://. The underlying paho.mqtt.golang library already supports WebSocket transport - this change simply passes the scheme through correctly. This enables publishing to MQTT brokers that only expose WebSocket endpoints (e.g. wss://broker.example.com:443).
Contributor
|
Thanks so much for the pull request! |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WebSocket (
ws://) and WebSocket Secure (wss://) transport support to the MQTT output plugin.Motivation
Many MQTT brokers (e.g., cloud-hosted or behind ingress controllers) only expose WebSocket endpoints. The MQTT input plugin (
mqtt_consumer) already supportsws://— this brings parity to the output.Changes
plugins/common/mqtt/mqtt_v3.go— preservews/wssschemes instead of overriding totlsplugins/common/mqtt/mqtt_v5.go— same fix for the v5 clientplugins/outputs/mqtt/sample.conf— documentws://andwss://in the scheme listNotes
The underlying
paho.mqtt.golanglibrary already supports WebSocket transport — this change simply passes the scheme through correctly.Example config