Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update retention rule for CLOUD and OSS #7016

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 25, 2025

Closes #

Fix the bug when updating the retention period of buckets:

  • Before fix: set a retention period, eg. 1 hour, then change to never -> the retention period is still 1 hour
  • After fix: set a retention period, eg. 1 hour, then change to never -> the retention period changes to never

_ The recorded screen is the result when update in OSS
https://github.com/user-attachments/assets/88c03b7a-06fb-4f68-a66b-62bddf8217b8

_ The image is the result when update in CLOUD.
Note: I have to mock the variable CLOUD because I don't know how to run the CLOUD in my local. In the captured screen the retentionRules in the payload is not exists when send to the backend like ui team suggested
Screenshot 2025-02-25 at 15 14 05

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 requested review from a team as code owners February 25, 2025 08:36
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant