fix(calendar): remove duplicate information for screen-reader user #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerjanvangeest
requested review from
tlouisse,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: e361fba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
okadurin
reviewed
Jan 23, 2025
okadurin
approved these changes
Jan 23, 2025
gerjanvangeest
force-pushed
the
fix/calendar-a11y-duplication
branch
from
78e36c9 to
8cc6853
Compare
tlouisse
reviewed
Jan 23, 2025
tlouisse
requested changes
Jan 23, 2025
gerjanvangeest
force-pushed
the
fix/calendar-a11y-duplication
branch
from
05a6946 to
e361fba
Compare
gerjanvangeest
force-pushed
the
fix/calendar-a11y-duplication
branch
from
21cccbf to
e361fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
aria-labelledby="month year"from table. Each day already announces the month and year in the dayTemplate. So it got announced double.weekdayNamefrom dayTemplate - The weekday is also the table header, so if you move from one text element to another while using the screen-reader, you already hear the weekday announced.