Skip to content

refactor: migrate to init4-bin-base #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented May 20, 2025

updates builder to use the utils ported to bin-base

This was referenced May 20, 2025
Copy link
Member Author

prestwich commented May 20, 2025

@prestwich prestwich mentioned this pull request May 20, 2025
@prestwich prestwich marked this pull request as ready for review May 20, 2025 15:23
@prestwich prestwich force-pushed the prestwich/sdk-signer-oauth branch from 9bb3b73 to d395f2e Compare May 20, 2025 15:30
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

Base automatically changed from prestwich/cache-task to main May 23, 2025 18:01
@prestwich prestwich force-pushed the prestwich/sdk-signer-oauth branch from d395f2e to 730dabd Compare May 23, 2025 18:02
Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock since these changes are tested and the CI failures are a dependency issue.

)]
pub oauth_token_refresh_interval: u64,

/// Oauth2 configuration for the builder to connect to ini4 services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Oauth2 configuration for the builder to connect to ini4 services.
/// Oauth2 configuration for the builder to connect to init4 services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants