fix(server): reject invalid base64 metadata and tolerate trailing slash - #5
Merged
Conversation
- POST to base_path matched exactly; '/files/' returned 404 - tusd accepts both; tus-py-client builds URLs with trailing slash - match base_path and base_path + '/' in sync and async routers
- b64decode without validate=True silently drops non-alphabet chars - 'filename ####' decoded to '' instead of 400 - pass validate=True so malformed values are rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Two independent creation-endpoint hardening fixes, off current
main.Upload-Metadatavalues with400(was silently accepted → corrupted stored values)/files/==/files; some proxies/clients append/, POST returned 404)Test Plan
make ciTest Result
pytest -vgreen;ruff+ty checkcleanChecklist
type(scope): ...)pytest -vpasses locallyruff check/ruff format --check/ty check resumable_uploadcleanTUS_COMPLIANCE.mdupdated