Skip to content

Conversation

@KiruthikaJeyashankar
Copy link
Contributor

@KiruthikaJeyashankar KiruthikaJeyashankar commented Jan 22, 2026

maven publish artifacts failing due to sign task dependency issue, so added signTasks as dependent of publish tasks

Summary by CodeRabbit

  • Chores
    • Enhanced build process to enforce artifact signing before publishing to repositories. All artifacts are now required to be signed prior to distribution, ensuring secure and verified releases.

✏️ Tip: You can customize this high-level summary in your review settings.

maven publish artifacts failing due to sign task dependency issue, so added signTasks  as dependent of publish tasks

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

Adds an afterEvaluate block to the build configuration that establishes task dependencies, ensuring signing tasks execute before publication tasks. This guarantees artifacts are cryptographically signed before being pushed to Maven repositories.

Changes

Cohort / File(s) Summary
Build Configuration
kotlin/PixelPass/build.gradle.kts
Adds afterEvaluate block wiring signing tasks (signJarReleasePublication, signAarPublication) as dependencies for six publication tasks, ensuring artifacts are signed before publishing to local Maven, MavenLocal, and Pixelpass repositories.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • ckm007

Poem

🐰 A hop, a skip, a sign before we ship,
Dependencies dance in Gradle's grip,
Artifacts sealed with cryptographic care,
Now publishing safe through the digital air!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: maven publish workflow failure' directly and accurately describes the main change in the pull request, which addresses a maven publish workflow failure by wiring publish tasks to depend on signing tasks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@kotlin/PixelPass/build.gradle.kts`:
- Around line 197-204: The publishTasks list contains a typo: it uses
"publishJarPublicationToPixelpassRepository" which doesn't match the other
"jarRelease" entries, so update the entry in the publishTasks list to
"publishJarReleasePublicationToPixelpassRepository" to ensure the Pixelpass jar
publish task is recognized and the signing dependency is applied; locate the
publishTasks declaration and replace that single string accordingly.

@swatigoel swatigoel merged commit 5276ad9 into inji:develop Jan 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants