Skip to content

Conversation

@jaswanthkumartw
Copy link

@jaswanthkumartw jaswanthkumartw commented Jan 23, 2026

Summary by CodeRabbit

  • Refactor
    • Enhanced data decoding method with improved transformation capabilities and more flexible parameter options.
    • Improved Java interoperability for better library compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Walkthrough

The decodeMappedData method signature in the PixelPass class is updated to accept an array-based key mapper with a customizable value mapper function instead of a single map, while adding Java interoperability via @JvmOverloads annotation.

Changes

Cohort / File(s) Summary
Method Signature Update
kotlin/PixelPass/src/commonMain/kotlin/io/mosip/pixelpass/PixelPass.kt
Replaced decodeMappedData(data: String, mapper: Map<String, String>) overload with decodeMappedData(data: String, keyMapper: Array<Map<String, String>>, valueMapperFunction: (JSONObject) -> JSONObject) featuring @JvmOverloads annotation and default parameters pointing to CLAIM_169_REVERSE_KEY_MAPPER and Utils()::replaceValuesForClaim169. Retained existing Array<String> overload.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A mapper's dance, from single to array,
Keys transformed in a brand new way,
Java's smile with overloads bright,
PixelPass now claims the light,
Values mapped—oh what a sight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a @JvmOverloads annotation to expose a Java-friendly API for the decodeMappedData method for claim 169 decoding.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@swatigoel swatigoel merged commit 3cc2a6c into inji:develop Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants