New node tracing system support #594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnalotoski
commented
Mar 2, 2025
johnalotoski
commented
- WIP
* Update usePeersFromLedgerAfterSlot to useLedgerAfterSlot for consistent naming with the cardano-node topology file key. * It would be nice to put a deprecated warn for the legacy name in the environment for some time before removing it, but with eager evaluation of the cardanoLib environment set, either everybody sees the warn if present, or nobody does if missing. Since grep.app doesn't find any downstream uses of the legacy name beyond the repos already being updated, we'll simply remove the legacy named attr now.
johnalotoski
force-pushed
the
jl/new-tracing
branch
from
4b0b049 to
599a336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.