Stabilisation of cardano db v2 (aggregator)

[turmelclem]

Content

This PR includes...

mithril aggragtor :

• Remove CardanoImmutableFilesFull to keep only MithrilStakeDistribution in the DEFAULT_ALLOWED_DISCRIMINANTS
• add CardanoImmutableFilesFull in allowed_discriminants (signed entity config) of aggregator's tests
• add CardanoImmutableFilesFull in signed_entity_types of aggregator's integration tests

mithril signer :

• add CardanoImmutableFilesFull in signed entities of signer's integration tests

test-lab :

• add CardanoImmutableFilesFull in signed_entity_types of stress test

backward compatibility github action :

• add CardanoImmutableFilesFull in signed_entity_types of stress test

mithril client CLI & test-client.yml :

• rename cardano database directory from db_v2 to db when using cardano-db download --backend v2

and some documentation improvements

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)
  • Add ADR blog post or Dev ADR entry (if relevant)
  • No new TODOs introduced

Issue(s)

Closes #2577

[github-actions]

Test Results

    3 files  ±0    102 suites  ±0   16m 16s ⏱️ -20s
2 048 tests ±0  2 048 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 229 runs  ±0  4 229 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3438ccb. ± Comparison against base commit 63bc902.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.

mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_called_for_mithril_stake_distribution_and_then_for_immutable_file

mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_called_for_mithril_stake_distribution

♻️ This comment has been updated with latest results.

[Copilot]

Pull Request Overview

This PR stabilizes the Cardano DB v2 aggregator and signer tests by adjusting allowed discriminants and updating download directory parameters. Key changes include removing CardanoImmutableFilesFull from the default allowed discriminants, adding it explicitly in tests and configurations, and standardizing download directory naming with the new --download-dir option.

• Updated allowed discriminants in various configuration and test files.
• Revised CLI download commands to use a consistent directory naming scheme.
• Improved documentation to reflect these changes.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
mithril-test-lab/mithril-end-to-end/src/stress_test/aggregator_helpers.rs	Adds CardanoImmutableFilesFull to test configuration.
mithril-test-lab/mithril-end-to-end/src/mithril/client.rs	Introduces the --download-dir parameter for both v1 and v2 downloads.
mithril-test-lab/mithril-end-to-end/src/main.rs	Updates the default signed_entity_types to include CardanoImmutableFilesFull.
mithril-signer/tests/create_cardano_transaction_single_signature.rs	Updates tests to allow CardanoImmutableFilesFull as a signed entity.
mithril-common/src/entities/signed_entity_config.rs	Removes CardanoImmutableFilesFull from DEFAULT_ALLOWED_DISCRIMINANTS.
mithril-client-cli/src/commands/cardano_db/download/*	Refactors download commands to use a constant directory name (DB_DIRECTORY_NAME).
mithril-aggregator/tests/* & src/runtime/runner.rs	Adapts test helpers to handle the explicit allowed discriminants configuration.
docs/website/*	Adjusts documentation to reflect the new download directory logic and configuration changes.
.github/workflows/*	Updates CI workflow commands to include --download-dir with the appropriate directory names.

Comments suppressed due to low confidence (2)

mithril-aggregator/src/configuration.rs:491

• The documentation comment is unclear; consider rephrasing it to 'The value MithrilStakeDistribution is automatically prepended to the list.'

    /// The value `MithrilStakeDistribution` is prepended is automatically to the list.

docs/website/root/manual/develop/nodes/mithril-client.md:581

• Please verify that updating the default backend to 'v2' in the documentation aligns with the actual default behavior in the client implementation.

| `backend`                  | `--backend`                  |         `-b`         | -                          | -                                                                               | `v2`          | -       |         -          |