Decentralization of configuration parameters phase 1 #2702

turmelclem · 2025-09-24T13:09:51Z

Content

Introduce a new crate called mithril-protocol-config to retrieve information about the Mithril Network (like epoch settings and aggregator features).

This crate contains a new trait, MithrilNetworkConfigurationProvider, and a first implementation calling Aggregator REST API. (in the future, for the purpose of decentralization, a new implementation will be created reading the Cardanao chain).

Crate mithril-signer use this new trait instead of using its internal AggregatorClient.

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- All check jobs of the CI have succeeded
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)
- Add ADR blog post or Dev ADR entry (if relevant)
- No new TODOs introduced

Issue(s)

Relates to #YYY

internal/mithril-protocol-config/src/http_client/http_impl.rs

internal/mithril-network-config/src/http.rs

internal/mithril-protocol-config/src/interface.rs

github-actions · 2025-09-24T13:13:10Z

Test Results

4 files ± 0 168 suites +4 23m 26s ⏱️ -34s
2 219 tests + 26 2 219 ✅ + 26 0 💤 ±0 0 ❌ ±0
6 857 runs +104 6 857 ✅ +104 0 💤 ±0 0 ❌ ±0

Results for commit 9ccbbe3. ± Comparison against base commit 098106d.

This pull request removes 1 and adds 27 tests. Note that renamed tests count towards both.

mithril-signer ‑ runtime::runner::tests::test_inform_epoch_setting_pass_allowed_discriminant_to_epoch_service

mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_ko_500
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_ko_json_serialization
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_ok_200
mithril-protocol-config ‑ http_client::aggregator_client::tests::aggregator_features::test_aggregator_features_timeout
mithril-protocol-config ‑ http_client::aggregator_client::tests::epoch_settings::test_epoch_settings_ko_500
mithril-protocol-config ‑ http_client::aggregator_client::tests::epoch_settings::test_epoch_settings_ok_200
mithril-protocol-config ‑ http_client::aggregator_client::tests::epoch_settings::test_epoch_settings_timeout
mithril-protocol-config ‑ http_client::aggregator_client::tests::test_4xx_errors_are_handled_as_remote_server_logical
mithril-protocol-config ‑ http_client::aggregator_client::tests::test_550_error_is_handled_as_registration_round_not_yet_opened
mithril-protocol-config ‑ http_client::aggregator_client::tests::test_5xx_errors_are_handled_as_remote_server_technical
…

♻️ This comment has been updated with latest results.

internal/mithril-protocol-config/src/http_client/aggregator_client.rs

internal/mithril-protocol-config/src/http/from_epoch_settings.rs

internal/mithril-protocol-config/src/http_client/http_impl.rs

internal/mithril-protocol-config/src/lib.rs

internal/mithril-protocol-config/src/http_client/aggregator_client.rs

internal/mithril-protocol-config/src/http_client/http_impl.rs

internal/mithril-protocol-config/src/lib.rs

github-advanced-security

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

internal/mithril-protocol-config/README.md

README.md

internal/mithril-protocol-config/src/test/double/fake_data.rs

internal/mithril-protocol-config/src/http_client/aggregator_client.rs

internal/mithril-protocol-config/src/test/double/fake_data.rs

…rait to retrieve epoch setting

…onfig

…d in HashMap

…th available signe entity type and config

…ionProvider

…tionProvider

…MithrilNetworkConfiguration, adapt inform_epoch_settings signature

…ationProvider

…d next signers

…f Aggregator client for the preloader checker

…ork configuration

jpraynaud · 2025-10-08T14:20:55Z

internal/mithril-protocol-config/src/http_client/aggregator_client.rs

+
+    /// No signer registration round opened yet
+    #[error("a signer registration round is not opened yet, please try again later")]
+    RegistrationRoundNotYetOpened(#[source] StdError),


I'm not sure that this variant is used in this context. You can probably remove it.

jpraynaud · 2025-10-08T14:26:11Z

internal/mithril-protocol-config/src/lib.rs

You should add this at the beginning of the lib.rs to enforce correct documentation of public items in the crate:
#![warn(missing_docs)]

jpraynaud · 2025-10-08T14:29:23Z

internal/mithril-protocol-config/Cargo.toml

+[package]
+name = "mithril-protocol-config"
+version = "0.1.0"
+description = "Configuraton parameters of the mithril network"


Suggested change

description = "Configuraton parameters of the mithril network"

description = "Configuraton parameters for Mithril networks"

jpraynaud · 2025-10-08T14:29:57Z

internal/mithril-protocol-config/Cargo.toml

+tokio = { workspace = true, features = ["macros", "rt-multi-thread", "signal"] }
+
+[dev-dependencies]
+#criterion = { version = "0.7.0", features = ["html_reports", "async_tokio"] }


This can be removed:

Suggested change

#criterion = { version = "0.7.0", features = ["html_reports", "async_tokio"] }

jpraynaud · 2025-10-08T14:32:45Z

internal/mithril-protocol-config/src/http_client/mod.rs

You could let the aggregator_client module outside of the http_client as it is going to be replaced with the internal shared implementation. Like that you would have a single file module right away.

jpraynaud · 2025-10-08T14:33:12Z

internal/mithril-protocol-config/src/interface.rs

+
+use crate::model::MithrilNetworkConfiguration;
+
+/// Trait to provide the current Mithril network configuration.


Suggested change

/// Trait to provide the current Mithril network configuration.

/// A provider for the Mithril network configuration of the current epoch.

jpraynaud · 2025-10-08T14:34:12Z

internal/mithril-protocol-config/src/lib.rs

@@ -0,0 +1,11 @@
+/// HTTP request timeout duration in milliseconds
+const HTTP_REQUEST_TIMEOUT_DURATION: u64 = 30000;


This can probably be moved in the aggregator_client module.

jpraynaud · 2025-10-08T14:59:29Z

internal/mithril-protocol-config/src/test/double/mithril_network_configuration_provider.rs

+    async fn get_time_point(&self) -> Result<TimePoint, Error> {
+        let time_point = self.ticker_service.get_current_time_point().await?;
+
+        Ok(time_point)
+    }
+
+    pub async fn change_allowed_discriminants(
+        &self,
+        discriminants: &BTreeSet<SignedEntityTypeDiscriminants>,
+    ) {
+        let mut available_signed_entity_types = self.available_signed_entity_types.write().await;
+        *available_signed_entity_types = discriminants.clone();
+    }


Do we need these functions? If not, maybe you can get rid of RwLock which are only interesting here to provide interior mutability.

yes its used in state_machine_tester.rs by function aggregator_allow_signed_entities, function called in test_create_cardano_transaction_single_signature (in mithril-signer) to setup specific signed entity type discriminant (we add the same mecanism with Signer epoch setting before)

get_time_point was used to have a Epoch align with ticker service and with other epochs used in the test test_create_cardano_transaction_single_signature, but since I switch back to epoch from epoch_settings (here) It can be replace with a Epoch::dummy() instead (since its not read for now)

jpraynaud · 2025-10-08T14:59:52Z

internal/mithril-protocol-config/src/test/double/mithril_network_configuration_provider.rs

+        let time_point = self.get_time_point().await?;
+
+        let available_signed_entity_types = self.available_signed_entity_types.read().await;


Suggested change

let time_point = self.get_time_point().await?;

let available_signed_entity_types = self.available_signed_entity_types.read().await;

let time_point = self.get_time_point().await?;

let available_signed_entity_types = self.available_signed_entity_types.read().await;

jpraynaud · 2025-10-08T15:00:54Z

internal/mithril-protocol-config/src/test/double/mithril_network_configuration_provider.rs

+    pub signed_entity_types_config:
+        HashMap<SignedEntityTypeDiscriminants, SignedEntityTypeConfiguration>,
+
+    ticker_service: Arc<MithrilTickerService>,


You can probably use an Epoch here instead of a ticker service.

jpraynaud · 2025-10-08T15:02:20Z

internal/mithril-protocol-config/src/interface.rs

+#[async_trait]
+pub trait MithrilNetworkConfigurationProvider: Sync + Send {
+    /// Get the Mithril network configuration for the current epoch.
+    async fn get(&self) -> StdResult<MithrilNetworkConfiguration>;


Maybe this is more explicit:

Suggested change

async fn get(&self) -> StdResult<MithrilNetworkConfiguration>;

async fn get_network_configuration(&self) -> StdResult<MithrilNetworkConfiguration>;

jpraynaud · 2025-10-08T15:03:31Z

mithril-common/src/entities/protocol_parameters.rs


 /// Protocol cryptographic parameters
-#[derive(Clone, Debug, Serialize, Deserialize)]
+#[derive(Clone, Debug, Serialize, Deserialize, Default)]


We don't want to provide a default implementation for the protocol parameters:

Suggested change

#[derive(Clone, Debug, Serialize, Deserialize, Default)]

#[derive(Clone, Debug, Serialize, Deserialize)]

jpraynaud · 2025-10-08T15:06:35Z

mithril-signer/src/runtime/runner.rs

 /// This trait is mainly intended for mocking.
 #[async_trait]
 pub trait Runner: Send + Sync {
+    ///Fetch the configuration parameters of a Mithril network


Suggested change

///Fetch the configuration parameters of a Mithril network

/// Fetch the configuration parameters of the Mithril network

jpraynaud · 2025-10-08T15:08:07Z

mithril-signer/src/runtime/runner.rs

-    async fn inform_epoch_settings(&self, epoch_settings: SignerEpochSettings) -> StdResult<()>;
+    async fn inform_epoch_settings(
+        &self,
+        signer_epoch: Epoch,


This is more the epoch retrieved from the aggregator than from the signer:

Suggested change

signer_epoch: Epoch,

aggregator_epoch: Epoch,

Or better:

Suggested change

signer_epoch: Epoch,

aggregator_signer_registration_epoch: Epoch,

jpraynaud · 2025-10-08T15:10:20Z

mithril-signer/src/runtime/runner.rs

+        let network_configuration_service = Arc::new(FakeMithrilNetworkConfigurationProvider::new(
+            Default::default(),
+            Default::default(),
+            Default::default(),
+            ticker_service.clone(),
+        ));


The instantiation of the Fake provider is hard to read with all these Default::default(), can you try to make it more readable?

jpraynaud · 2025-10-08T15:10:58Z

mithril-signer/src/runtime/runner.rs

-        let epoch_settings = SignerEpochSettings {
-            epoch: Epoch(1),
-            ..SignerEpochSettings::dummy()
+        // Signers


Suggested change

// Signers

jpraynaud · 2025-10-08T15:12:27Z

mithril-signer/src/runtime/state_machine.rs

-                } else if let Some(epoch_settings) = self
+                } else if let Some(signer_registrations) = self
                    .runner
                    .get_epoch_settings()


This function could be renamed for more readability:

Suggested change

.get_epoch_settings()

.get_signer_registrations_from_aggregator()

jpraynaud · 2025-10-08T15:12:54Z

mithril-signer/src/runtime/state_machine.rs

+                        .get_mithril_network_configuration()
+                        .await
+                        .map_err(|e| RuntimeError::KeepState {
+                            message: "could not retrieve mithril network configuration".to_string(),


Suggested change

message: "could not retrieve mithril network configuration".to_string(),

message: "could not retrieve Mithril network configuration".to_string(),

jpraynaud · 2025-10-08T15:17:22Z

mithril-signer/src/services/epoch_service.rs


-        // Epoch settings
-        let epoch_settings = SignerEpochSettings {
+        //MithrilNetworkConfiguration


Suggested change

//MithrilNetworkConfiguration

// MithrilNetworkConfiguration

jpraynaud · 2025-10-08T15:19:24Z

mithril-signer/src/services/epoch_service.rs

+            let mut signed_entity_types_config = HashMap::new();
+            signed_entity_types_config.insert(
+                SignedEntityTypeDiscriminants::CardanoTransactions,
+                SignedEntityTypeConfiguration::CardanoTransactions(
+                    CardanoTransactionsSigningConfig::dummy(),
+                ),
+            );


You can also avoid creating a mutable map by using HashMap::from.

jpraynaud · 2025-10-08T15:20:05Z

mithril-signer/tests/test_extensions/certificate_handler.rs


    #[tokio::test]
    async fn retrieve_epoch_settings() {
+        //TODO split in two tests, to test only signers from retrieve_epoch_settings and CardanoTransactionsSigningConfig in a mithril_network_configuration_provider test ?


Can we remove this TODO?

jpraynaud · 2025-10-08T15:20:13Z

mithril-signer/tests/test_extensions/certificate_handler.rs


    #[tokio::test]
    async fn retrieve_aggregator_features() {
+        //TODO aggregator features are now retrieved with mithril_network_configuration_provider, adapt or remove test and implementation ?


Can we also remove this TODO?

Alenar · 2025-10-08T13:41:51Z

internal/mithril-protocol-config/Cargo.toml

+reqwest = { workspace = true, features = [
+    "default",
+    "stream",
+    "gzip",
+    "zstd",
+    "deflate",
+    "brotli"
+] }
+semver = { workspace = true }
+serde = { workspace = true }
+serde_json = { workspace = true }
+slog = { workspace = true, features = [
+    "max_level_trace",
+    "release_max_level_debug",
+] }
+thiserror = { workspace = true }
+tokio = { workspace = true, features = ["macros", "rt-multi-thread", "signal"] }
+
+[dev-dependencies]
+#criterion = { version = "0.7.0", features = ["html_reports", "async_tokio"] }
+http = "1.3.1"
+httpmock = "0.7.0"
+mockall = { workspace = true }
+slog-async = { workspace = true }
+slog-term = { workspace = true }


In library crates if a feature is not strictly needed by the business code, we should not enable them, as rust feature unification will enforce them on child crates.
Especially features on reqwest, slog, and tokio as they may involve building additional dependencies that childs crates want to control, or even worse the **max_level** features of slog as they will remove the ability to configure them on child crates.

Suggested change

reqwest = { workspace = true, features = [

"default",

"stream",

"gzip",

"zstd",

"deflate",

"brotli"

] }

semver = { workspace = true }

serde = { workspace = true }

serde_json = { workspace = true }

slog = { workspace = true, features = [

"max_level_trace",

"release_max_level_debug",

] }

thiserror = { workspace = true }

tokio = { workspace = true, features = ["macros", "rt-multi-thread", "signal"] }

[dev-dependencies]

#criterion = { version = "0.7.0", features = ["html_reports", "async_tokio"] }

http = "1.3.1"

httpmock = "0.7.0"

mockall = { workspace = true }

slog-async = { workspace = true }

slog-term = { workspace = true }

reqwest = { workspace = true }

semver = { workspace = true }

serde = { workspace = true }

serde_json = { workspace = true }

slog = { workspace = true }

thiserror = { workspace = true }

tokio = { workspace = true }

[dev-dependencies]

http = "1.3.1"

httpmock = "0.7.0"

mockall = { workspace = true }

slog-async = { workspace = true }

slog-term = { workspace = true }

tokio = { workspace = true, features = ["macros"] }

Alenar · 2025-10-08T14:04:11Z

internal/mithril-protocol-config/src/lib.rs

@@ -0,0 +1,11 @@
+/// HTTP request timeout duration in milliseconds


Missing missing_docs clippy warn and a lib documentation.

Note
This warning addition will results in additional clippy warnings that must be solved if some public symbols or modules are undocumented.

Suggested change

/// HTTP request timeout duration in milliseconds

#![warn(missing_docs)]

//! This crate provides mechanisms to read and check the configuration parameters of a Mithril network.

/// HTTP request timeout duration in milliseconds

Alenar · 2025-10-08T14:21:38Z

internal/mithril-protocol-config/src/http_client/http_impl.rs

+use anyhow::anyhow;
+use std::{collections::HashMap, sync::Arc, time::Duration};
+
+use crate::{
+    HTTP_REQUEST_TIMEOUT_DURATION,
+    http_client::aggregator_client::{AggregatorClient, AggregatorHTTPClient},
+    interface::MithrilNetworkConfigurationProvider,
+    model::{MithrilNetworkConfiguration, SignedEntityTypeConfiguration},
+};
+use async_trait::async_trait;
+use mithril_common::api_version::APIVersionProvider;
+use mithril_common::{StdResult, entities::SignedEntityTypeDiscriminants};


Can you try to enforce the following import order ?

use std and third parties
[blank line]
use mithril libraries
[blank line]
use crate

Note
You may split std and third parties imports with a blank line as well if you want (with std first).

Important
This comment apply to the whole crate

Suggested change

use anyhow::anyhow;

use std::{collections::HashMap, sync::Arc, time::Duration};

use crate::{

HTTP_REQUEST_TIMEOUT_DURATION,

http_client::aggregator_client::{AggregatorClient, AggregatorHTTPClient},

interface::MithrilNetworkConfigurationProvider,

model::{MithrilNetworkConfiguration, SignedEntityTypeConfiguration},

};

use async_trait::async_trait;

use mithril_common::api_version::APIVersionProvider;

use mithril_common::{StdResult, entities::SignedEntityTypeDiscriminants};

use anyhow::anyhow;

use async_trait::async_trait;

use std::{collections::HashMap, sync::Arc, time::Duration};

use mithril_common::api_version::APIVersionProvider;

use mithril_common::{StdResult, entities::SignedEntityTypeDiscriminants};

use crate::{

HTTP_REQUEST_TIMEOUT_DURATION,

http_client::aggregator_client::{AggregatorClient, AggregatorHTTPClient},

interface::MithrilNetworkConfigurationProvider,

model::{MithrilNetworkConfiguration, SignedEntityTypeConfiguration},

};

Alenar · 2025-10-08T14:24:07Z

internal/mithril-protocol-config/Cargo.toml

+edition = { workspace = true }
+homepage = { workspace = true }
+license = { workspace = true }
+repository = { workspace = true }


Other internal crates add a include property, but since there's no .gitignore it may not be needed here.

Suggested change

repository = { workspace = true }

repository = { workspace = true }

include = ["**/*.rs", "Cargo.toml", "README.md", ".gitignore"]

Alenar · 2025-10-08T14:44:34Z

mithril-common/src/entities/protocol_parameters.rs


 /// Protocol cryptographic parameters
-#[derive(Clone, Debug, Serialize, Deserialize)]
+#[derive(Clone, Debug, Serialize, Deserialize, Default)]


A Default impl should not be added lightly, and should not be added for test purpose (use Dummy or fake_data instead)

Suggested change

#[derive(Clone, Debug, Serialize, Deserialize, Default)]

#[derive(Clone, Debug, Serialize, Deserialize)]

Alenar · 2025-10-08T15:43:14Z

mithril-signer/src/dependency_injection/builder.rs

        let metrics_service = Arc::new(MetricsService::new(self.root_logger())?);
-        let preloader_activation =
-            CardanoTransactionsPreloaderActivationSigner::new(aggregator_client.clone());
+        let network_configuration_service: Arc<dyn MithrilNetworkConfigurationProvider> =


Is the explicit Arc<dyn MithrilNetworkConfigurationProvider> type necessary ?

Alenar · 2025-10-08T15:49:01Z

mithril-signer/src/runtime/state_machine.rs

    async fn transition_from_unregistered_to_one_of_registered_states(
        &self,
-        epoch_settings: SignerEpochSettings,
+        signer_epoch: Epoch,


Since it came from the epoch settings it's not the signer epoch, it's the aggregator epoch.

Suggested change

signer_epoch: Epoch,

aggregator_epoch: Epoch,

This have some implications that we should discuss, by the way it was already the case before but we simply named it epoch so the we missed that point.

Alenar · 2025-10-08T15:49:39Z

mithril-signer/src/runtime/state_machine.rs

@@ -1,20 +1,17 @@
 use anyhow::Error;
 use chrono::Local;
+use mithril_protocol_config::model::MithrilNetworkConfiguration;


Can you move this import below the mithril import imports ?

Alenar · 2025-10-08T15:50:26Z

mithril-signer/src/runtime/state_machine.rs

    use anyhow::anyhow;
    use chrono::DateTime;
-    use mockall::predicate;
+    use mithril_protocol_config::model::MithrilNetworkConfiguration;


Already imported in the parent context :).

Suggested change

use mithril_protocol_config::model::MithrilNetworkConfiguration;

Alenar · 2025-10-08T15:59:16Z

mithril-signer/src/services/epoch_service.rs

        &mut self,
-        epoch_settings: SignerEpochSettings,
-        allowed_discriminants: BTreeSet<SignedEntityTypeDiscriminants>,
+        signer_epoch: Epoch,


aggregator or signer epoch ? See comment in state_machine.rs

turmelclem changed the title ~~Ctl/2692 decentralization of configuration parameters phase 1~~ Decentralization of configuration parameters phase 1 Sep 24, 2025

github-advanced-security bot found potential problems Sep 24, 2025

View reviewed changes

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from 43f79ef to b890de0 Compare September 24, 2025 14:36

github-advanced-security bot found potential problems Sep 25, 2025

View reviewed changes

github-advanced-security bot found potential problems Sep 26, 2025

View reviewed changes

jpraynaud reviewed Sep 29, 2025

View reviewed changes

internal/mithril-protocol-config/README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 3682084 to 910faf9 Compare September 30, 2025 13:00

turmelclem self-assigned this Sep 30, 2025

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 3 times, most recently from 0f0d971 to d4a42de Compare September 30, 2025 15:24

github-advanced-security bot found potential problems Sep 30, 2025

View reviewed changes

internal/mithril-protocol-config/src/test/double/fake_data.rs Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 30, 2025

View reviewed changes

internal/mithril-protocol-config/src/http_client/aggregator_client.rs Fixed Show fixed Hide fixed

internal/mithril-protocol-config/src/http_client/aggregator_client.rs Fixed Show fixed Hide fixed

internal/mithril-protocol-config/src/http_client/aggregator_client.rs Fixed Show fixed Hide fixed

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 683fd96 to 73af399 Compare October 3, 2025 15:15

github-advanced-security bot found potential problems Oct 3, 2025

View reviewed changes

internal/mithril-protocol-config/src/test/double/fake_data.rs Fixed Show fixed Hide fixed

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 3 times, most recently from e944a36 to 4b89712 Compare October 6, 2025 14:51

turmelclem added 8 commits October 6, 2025 17:02

feature(protocol-config): init a new crate, with http impl of a new t…

2aff742

…rait to retrieve epoch setting

feature(protocol-config): add and update makefiles

af9629b

feature(protocol-config): rename http to http_client

3a920af

feature(protocol-config): switch to hashmap for signed_entity_types_c…

8e6fa48

…onfig

feature(protocol-config): put back aggregator_features route call

f0c506e

feature(common): make SignedEntitTypesDiscriminant Hashable to be use…

e3bc785

…d in HashMap

feature(protocol-config): build MithrilNetworkConfiguration result wi…

dacf327

…th available signe entity type and config

feature(protocol-config): add test double on MithrilNetworkConfigurat…

159de72

…ionProvider

turmelclem added 9 commits October 6, 2025 17:02

feature(protocol-config): make http implementation and struct public

1dc365b

feature(common): Derive Default for ProtocolParameters for tests

42658ea

feature(signer): add dependency injection for MithrilNetworkConfigura…

a092441

…tionProvider

feature(protocol-config, signer): now retrieving epoch settings from …

837a88f

…MithrilNetworkConfiguration, adapt inform_epoch_settings signature

feature(protocol-config): improve tests of FakeMithrilNetworkConfigur…

0446945

…ationProvider

refactor(signer): refactor test, remove dead code

66e81d8

refactor(signer): variable renaming, remove usage of predicate in tests

f01d7df

feature(signer): improve log of inform_epoch_settings with current an…

82ab165

…d next signers

feature(signer): use Mithril Network configuration Provider instead o…

8ea7d61

…f Aggregator client for the preloader checker

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 6c81af6 to 1a65b8c Compare October 6, 2025 16:02

turmelclem requested review from jpraynaud and Alenar October 6, 2025 16:04

refactor(protocol-config): sort cargo.toml dependencies

6488a66

turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from 1a65b8c to 6488a66 Compare October 6, 2025 16:18

turmelclem temporarily deployed to testing-preview October 6, 2025 16:35 — with GitHub Actions Inactive

feature(signer): use epoch from signer registration, not mithril netw…

9ccbbe3

…ork configuration

turmelclem temporarily deployed to testing-preview October 7, 2025 08:36 — with GitHub Actions Inactive

jpraynaud reviewed Oct 8, 2025

View reviewed changes

Alenar reviewed Oct 8, 2025

View reviewed changes

	description = "Configuraton parameters of the mithril network"
	description = "Configuraton parameters for Mithril networks"


		use crate::model::MithrilNetworkConfiguration;

		/// Trait to provide the current Mithril network configuration.

	/// Trait to provide the current Mithril network configuration.
	/// A provider for the Mithril network configuration of the current epoch.

		@@ -0,0 +1,11 @@
		/// HTTP request timeout duration in milliseconds
		const HTTP_REQUEST_TIMEOUT_DURATION: u64 = 30000;

		let time_point = self.get_time_point().await?;

		let available_signed_entity_types = self.available_signed_entity_types.read().await;

	async fn get(&self) -> StdResult<MithrilNetworkConfiguration>;
	async fn get_network_configuration(&self) -> StdResult<MithrilNetworkConfiguration>;

	#[derive(Clone, Debug, Serialize, Deserialize, Default)]
	#[derive(Clone, Debug, Serialize, Deserialize)]

	///Fetch the configuration parameters of a Mithril network
	/// Fetch the configuration parameters of the Mithril network

	signer_epoch: Epoch,
	aggregator_signer_registration_epoch: Epoch,

	.get_epoch_settings()
	.get_signer_registrations_from_aggregator()

	message: "could not retrieve mithril network configuration".to_string(),
	message: "could not retrieve Mithril network configuration".to_string(),

	repository = { workspace = true }
	repository = { workspace = true }
	include = ["*/.rs", "Cargo.toml", "README.md", ".gitignore"]

Decentralization of configuration parameters phase 1 #2702

Are you sure you want to change the base?

Decentralization of configuration parameters phase 1 #2702

Uh oh!

Conversation

turmelclem commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Issue(s)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

turmelclem Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

turmelclem commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading

turmelclem Oct 8, 2025 •

edited

Loading